Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary innerHTML in code #119

Merged
merged 4 commits into from
Dec 1, 2023
Merged

Remove unnecessary innerHTML in code #119

merged 4 commits into from
Dec 1, 2023

Conversation

jvigliotta
Copy link
Collaborator

@jvigliotta jvigliotta commented Nov 16, 2023 •
edited by davetsay
Loading

Closes #118

  • added a url sanitizer library for links
  • using it in links to sanitize user provided url
  • switched to innerText for link as well
  • removed an unproblematic use of innerHTML in loginService code and optimized it (loginService may not be used anymore)

@jvigliotta jvigliotta requested a review from davetsay November 16, 2023 21:27
davetsay
davetsay requested changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look great. Can you re-target the base branch in case this does not get approved for R5.2?

davetsay
davetsay approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@davetsay davetsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davetsay davetsay merged commit e434511 into main Dec 1, 2023
@davetsay davetsay deleted the innerhtml-removal branch December 1, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davetsay davetsay davetsay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should prevent use of user input in innerHTML
2 participants
@jvigliotta @davetsay