initial cut at thread throttling / memory management #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
galenatjpl
commented
Dec 2, 2020
galenatjpl
commented
- added basic SQS thread throttling
- cleanup of AWS client resources
- bumped AWS SDK library version to near latest
* cleanup of AWS client resources * bumped AWS SDK library version to near latest
ztaylor54
requested changes
Dec 2, 2020
There was a problem hiding this comment.
Great work @galenatjpl! Looks good to me, I only have a few minor changes.
| @@ -26,25 +26,30 @@ | |||
| * @author ghollins, jwood, ztaylor | |||
| */ | |||
| public class S3DataManager { | |||
There was a problem hiding this comment.
Suggested change
| public class S3DataManager { | |
| public class S3DataManager implements AutoClosable { |
I'd suggest we instead make this class AutoClosable, so that it'll get cleaned up even in sneaky places we don't expect. It also allows us to use the try with resources paradigm instead of try...finally.
|
|
||
| public void close() { |
There was a problem hiding this comment.
Suggested change
| public void close() { | |
| @Override | |
| public void close() throws Exception { |
Add override annotation for AutoClosable interface
| @@ -406,46 +406,49 @@ private void scheduleIfNotAlready(String initiationTrigger, Map<String,String> p | |||
| protected synchronized boolean skipScheduling(Map<String,String> partners) { | |||
| S3DataManager s3 = new S3DataManager(aws_default_region); | |||
There was a problem hiding this comment.
Suggested change
| S3DataManager s3 = new S3DataManager(aws_default_region); |
Define below in try with resources block
Comment on lines
450
to
452
| finally { | ||
| s3.close(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| finally { | |
| s3.close(); | |
| } |
s3 will be automatically cleaned up by the try with resources block
|
Hi @ztaylor54, I've implemented the above recommended changes by you. Please take a look. |
ztaylor54
approved these changes
Dec 16, 2020
jamesfwood
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Add error handling if mimetype is not set. * Add column for "edit" and "delete" buttons * Change "Delete" to "Stop Running" * Update Output Table. Move to top table. * Add warning for output vars, move style into css * Implement output_display_order support * Don't display output_display_order * Update processes page to consider order output var * Add test model * Update logs css * Add model * Update test * Move model to correct folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.