Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI lib updates 1 #178

Merged
merged 31 commits into from
Oct 27, 2023
Merged

UI lib updates 1 #178

merged 31 commits into from
Oct 27, 2023

Conversation

brentjk
Copy link
Collaborator

@brentjk brentjk commented Sep 12, 2023

Update jQuery to 3.7.0
Update Bootstrap to 3.3.7
Update Ace Editor to v1.5.0

@jamesfwood jamesfwood requested review from wcgunter and removed request for wcgunter September 12, 2023 17:10
@brentjk
Copy link
Collaborator Author

brentjk commented Sep 13, 2023

Passes sanity check. will run all pages and will run sample process.

@brentjk
Copy link
Collaborator Author

brentjk commented Sep 26, 2023

Branch definitely is working but its the testing that I'm currently troubleshooting.

@brentjk
Copy link
Collaborator Author

brentjk commented Sep 26, 2023

"WARNING: Unable to find an exact match for CDP version 117, so returning the closest version found: 115"

@brentjk
Copy link
Collaborator Author

brentjk commented Sep 26, 2023

selinum v4.13.0 - is the first compatible with 117

@brentjk
Copy link
Collaborator Author

brentjk commented Sep 27, 2023

Running a test branch. Looks like some of the xml files are not coming through as intended and some of the table data is not seen during a page search.

@brentjk
Copy link
Collaborator Author

brentjk commented Oct 3, 2023

Clearly displaying log correctly but now showing 'graphite' text for the LogsTestIT-runOutputTest. Need to better understand graphite to see how its working under the hood. Are we missing some log set or other needed element.

@brentjk
Copy link
Collaborator Author

brentjk commented Oct 3, 2023

No errors for the :"Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 48.321 s <<< FAILURE! - in jpl.cws.test.integration.ui.InitiatorsTestIT" going to need to step through to actually see what's happening. Looks fine on personal and server check.

@brentjk
Copy link
Collaborator Author

brentjk commented Oct 9, 2023

**note \@test to skip test

@brentjk
Copy link
Collaborator Author

brentjk commented Oct 12, 2023

Ok only 3 failures left:

Have some "temp" prints that need cleaned up before can be merged.

1.) Graphite not found on page
Part of test: ------ START LogsTestIT:runOutputTest ------

INSTALLER: 2023-10-10T03:13:54,232 ERROR [                main]       jpl.cws.test.WebTestUtil( 155) - text 'Graphite' NOT FOUND on page

java.lang.AssertionError: text 'Graphite' NOT FOUND on page

This has something to do with graphite logging. not sure what yet.

2.) runStartInitiatorTest

suspect its loosing object within a table

INSTALLER: 2023-10-10T03:18:33,947 INFO [ main] ntegration.ui.InitiatorsTestIT( 172) - No stats for this process
INSTALLER: 2023-10-10T03:18:33,947 INFO [ main] ntegration.ui.InitiatorsTestIT( 185) - ------ END

3.) runResultsTest
This is loosing object modifed by js. It saves the element 'history button' but crashes after calling it later.

@wcgunter
Copy link
Collaborator

wcgunter commented Oct 16, 2023

For 1 I feel like the jQuery migration updated a function that is used to load/manipulate the data. I'm re-adding the migrate plugin and printing the console log to see if I can get any clues.

@wcgunter wcgunter marked this pull request as ready for review October 25, 2023 17:52
@wcgunter wcgunter removed their request for review October 25, 2023 18:33
@jamesfwood jamesfwood merged commit bc9888c into develop Oct 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants