Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ids9941 301 return v2 #155

Merged
merged 10 commits into from
Jul 20, 2023
Merged

Conversation

brentjk
Copy link
Collaborator

@brentjk brentjk commented Jun 29, 2023

No description provided.

@brentjk brentjk changed the base branch from main to develop June 29, 2023 22:20
@jamesfwood
Copy link
Collaborator

You'll probably need to update the CI tests to expect the 301 instead of 200

@wcgunter
Copy link
Collaborator

I think I found something that might be causing the test failures:

Looking at the screenshots the tests made, the AJAX request is failing. According to documentation, Any error code that is outside of the interval [200, 299] and different than 304 is considered an error by jQuery when making an AJAX call.

I think it was returning 200 before (which would be considered successful) but 301 is not in the "successful" range.

@brentjk
Copy link
Collaborator Author

brentjk commented Jul 18, 2023

I see what you are saying @wcgunter I don't think that's the case here. But haven't used AJAX or jQuery very much to be certain. I'm seeing the assertion on RestPostTaskTest.java being the cause of the failure. I do think I'm set up slightly differently locally then the server checks as I'm passing local tests. Running a check putting it back to 200 to see how it behaves.

@brentjk brentjk force-pushed the feature/IDS9941_301ReturnV2 branch from 9b7a3fc to 58676f1 Compare July 18, 2023 19:55
@jamesfwood jamesfwood merged commit 35d7958 into develop Jul 20, 2023
@jamesfwood jamesfwood deleted the feature/IDS9941_301ReturnV2 branch July 20, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants