UI - Add and implement data tables #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-workflow-service into ui-history-download-log
jamesfwood
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the local download of DataTables as well as the implementation of some basic DataTables on the History, Deployments, and Processes pages.
Added a "Download" action button on the History page which allows the user to download the entire history log as JSON or CSV.
Fixed sorting when clicking on column header (removed manual sorting implementation and replaced with DataTable's sorting methods).
Processes page has been edited to remove the old pagination solution to replace it with DataTable's pagination solution. As a result, the way data is requested from the API has changed. Instead of receiving 200 at a time, the initial page load requests the 5000 most recent processes. If more are needed, the user can use the buttons added to the Processes page to load more/less in batches of 5000 (and a button to load all).
Also fixes the automated integration tests which were expecting the old filtering system for the processes page.
DataTables will be implemented on the Logs page in an upcoming PR.