Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Allow appropriate buttons to open in a new tab #152

Merged
merged 9 commits into from
Jun 14, 2023

Conversation

wcgunter
Copy link
Collaborator

This PR alters buttons on some pages to turn them into anchor tags to allow users to use right click -> open in new tab.

Updated buttons:

  • History button on Processes page
  • Subprocs button on Processes page
  • Filter button on Processes page
  • Filter button on Logs page

As part of updating the button tags to anchor tags, some tests needed to be updated to reflect that. The following tests have been updated to change the xpath of the "button" to look for an anchor tag:

  • HistoryTestIT.java
  • WebTestIT.java
  • InitiatorsTestIT.java
  • SnippetsTestIT.java

Images of right-click menu on these buttons:
Screenshot 2023-06-13 at 12 56 32 PM
image

Copy link
Collaborator

@jamesfwood jamesfwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks for updating the tests too. We need to make sure to keep those up-to-date.

@jamesfwood jamesfwood merged commit 5f9e8fc into develop Jun 14, 2023
@jamesfwood jamesfwood deleted the ui-buttons-update branch June 14, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants