Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Persistent states #151

Merged
merged 16 commits into from
Jun 13, 2023
Merged

UI - Persistent states #151

merged 16 commits into from
Jun 13, 2023

Conversation

wcgunter
Copy link
Collaborator

@wcgunter wcgunter commented Jun 8, 2023

Changes behavior of UI elements to remember their last states and restore them when loading the page again. Uses local storage to record and compare current states.

Also fixes issue on log page with the optional columns with auto-refresh (would remove the header labels for the optional column, flipped the checkmark meaning)

@wcgunter wcgunter self-assigned this Jun 8, 2023
@wcgunter wcgunter changed the title UI deployments refresh fix UI - Persistent state of drop down menus on Deployments page Jun 8, 2023
@wcgunter wcgunter changed the title UI - Persistent state of drop down menus on Deployments page UI - Persistent states on Deployments page Jun 9, 2023
@wcgunter wcgunter changed the title UI - Persistent states on Deployments page UI - Persistent states Jun 9, 2023
@wcgunter wcgunter marked this pull request as draft June 9, 2023 20:39
@wcgunter wcgunter marked this pull request as ready for review June 9, 2023 22:33
Copy link
Collaborator

@jamesfwood jamesfwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test it thoroughly? Does it handle when you close the browser and reopen?
initial cases are good?
Do you think we need a "Reset Defaults" button? or not really needed?
Test in different browsers? Chrome, Safari, Firefox? Those 3 should be good for testing

install/cws-ui/deployments.ftl Outdated Show resolved Hide resolved
install/cws-ui/deployments.ftl Outdated Show resolved Hide resolved
install/cws-ui/logs.ftl Outdated Show resolved Hide resolved
install/cws-ui/deployments.ftl Outdated Show resolved Hide resolved
@wcgunter
Copy link
Collaborator Author

Completed testing of the changes: (including wiping any current local storage, navigating, exiting and re-opening, logging out/in)
✅ Chrome (Version 114.0.5735.106)
✅ Firefox (Version 102.12.0esr)
✅ Safari (Version 16.5)

In terms of a reset defaults button, I don't think its necessary because the user can always change / reselect for themselves (and keep certain settings while resetting others). If anyone else has a different thought process, let me know and I can add one in.

@jamesfwood jamesfwood merged commit 4b8d9d1 into develop Jun 13, 2023
@jamesfwood jamesfwood deleted the ui-deployments-refresh-fix branch June 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants