-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI - Persistent states #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test it thoroughly? Does it handle when you close the browser and reopen?
initial cases are good?
Do you think we need a "Reset Defaults" button? or not really needed?
Test in different browsers? Chrome, Safari, Firefox? Those 3 should be good for testing
…mmon-workflow-service into ui-deployments-refresh-fix
Completed testing of the changes: (including wiping any current local storage, navigating, exiting and re-opening, logging out/in) In terms of a reset defaults button, I don't think its necessary because the user can always change / reselect for themselves (and keep certain settings while resetting others). If anyone else has a different thought process, let me know and I can add one in. |
Changes behavior of UI elements to remember their last states and restore them when loading the page again. Uses local storage to record and compare current states.
Also fixes issue on log page with the optional columns with auto-refresh (would remove the header labels for the optional column, flipped the checkmark meaning)