Added a default value to sequence adaptation names so migrations dont… #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohansen
force-pushed
the
feature/sequence-adaptation-names
branch
from
e998d96 to
295b304
Compare
Mythicaeda
reviewed
Jun 11, 2024
deployment/hasura/migrations/Aerie/5_sequence_adaptation_name/down.sql
Outdated
Show resolved
Hide resolved
Mythicaeda
reviewed
Jun 11, 2024
deployment/postgres-init-db/sql/tables/sequencing/sequence_adaptation.sql
Show resolved
Hide resolved
Mythicaeda
added
database
Mythicaeda
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… break
Description
The previous PR broke against a real migration because we didn't provide a default value for the
nameof asequence_adaptation. This adds a UUID.I tried using the current ID but that seemed more complicated for a problem that should be very low impact.
Verification
NA
Documentation
NA
Future work
NA