-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JDK/JRE + Gradle #1237
Update JDK/JRE + Gradle #1237
Conversation
Manual testing has shown:
So, upgrading the JRE of |
09021de
to
db46a8c
Compare
We should also update https://github.com/NASA-AMMOS/aerie-mission-model-template as well :) |
Reviewers of this PR should:
|
...er-driver/src/test/java/gov/nasa/jpl/aerie/scheduler/simulation/ResumableSimulationTest.java
Outdated
Show resolved
Hide resolved
Pending a couple questions that @skovati will look into:
|
db46a8c
to
628669c
Compare
628669c
to
eb2cb90
Compare
@Mythicaeda will test this with building the Clipper model in JDK 21 |
I've tested building the Clipper model against this branch. Once I was able to get the Clipper model to accept Java 21 artifacts, it compiled on J21 and simulated, although I do not do a deep dive into whether the results were the same as the version compiled on J19 using J19 Aerie artifacts (I did check a couple views, though, and didn't see any differences). However, in order to get Clipper to build I had to change the Clipper build process, as they specifically look for Java 19 artifacts and reject JARs compiled on other Java versions. This means that the version of Aerie that includes the J21 upgrade will be breaking to Clipper. Details for how to update Clipper model to support JDK 21:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested locally and it LGTM!
eb2cb90
to
95080d0
Compare
Merging to include with 2.4.0 release - thanks! |
Description
Updates JDK/JRE to 21, as well as Gradle to
8.48.6.Updates sim engine to only use virtual thread per-task executor. Removes a test that checks thread count in the sim driver since that fails with virtual threads. @Twisol
Verification
Just 👀'ing at e2e-tests
Future work
A few
TODO
s are now unblocked by this JDK update. (e.g.rg "TODO" | rg "21"
)