Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plan JSON export #1357

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Add plan JSON export #1357

merged 5 commits into from
Jul 10, 2024

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Jul 2, 2024

The download portion of #1154

To test:

  1. Create a plan
  2. Add some directives
  3. Move them around on the timeline
  4. Anchor some to other directives
  5. Set some directive arguments
  6. Open the "Plan Metadata" panel
  7. Click the Download icon on the right of the panel
  8. Verify that a JSON with the plan's name is downloaded
  9. Verify that all the activity arguments are defined

@duranb duranb requested a review from a team as a code owner July 2, 2024 20:13
@duranb duranb requested review from dandelany, AaronPlave and joswig July 2, 2024 20:13
@duranb duranb temporarily deployed to test-workflow July 2, 2024 20:13 — with GitHub Actions Inactive
@duranb duranb added the feature New feature or request label Jul 2, 2024
@duranb duranb self-assigned this Jul 2, 2024
@duranb duranb temporarily deployed to test-workflow July 2, 2024 22:18 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow July 3, 2024 00:42 — with GitHub Actions Inactive
@duranb duranb force-pushed the feature/download-plan-json branch from 4775889 to ec24e40 Compare July 8, 2024 15:25
@duranb duranb temporarily deployed to test-workflow July 8, 2024 15:25 — with GitHub Actions Inactive
@duranb duranb temporarily deployed to test-workflow July 8, 2024 17:32 — with GitHub Actions Inactive
src/components/plan/PlanForm.svelte Outdated Show resolved Hide resolved
@duranb duranb temporarily deployed to test-workflow July 10, 2024 00:35 — with GitHub Actions Inactive
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duranb duranb merged commit f25e68b into develop Jul 10, 2024
5 checks passed
@duranb duranb deleted the feature/download-plan-json branch July 10, 2024 20:20
AaronPlave pushed a commit that referenced this pull request Jul 10, 2024
* add plan JSON export
AaronPlave pushed a commit that referenced this pull request Jul 11, 2024
* add plan JSON export
cohansen pushed a commit that referenced this pull request Jul 16, 2024
* add plan JSON export
cohansen added a commit that referenced this pull request Jul 16, 2024
* Moved to a more general seq editor and adaptation

* Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time

* Fix plan metadata name input reset on snapshot preview (#1358)

* fix table action icons staying disabled when no longer in snapshot preview
* make table components less plan specific

* Add plan JSON export (#1357)

* add plan JSON export

* Hide plan export button (#1374)

* Release v2.15.0 (#1377)

Co-authored-by: joswig <[email protected]>

* Cleanup NumEditor and convert value to a number

Added tooltip support for repeat args

Removed utils.ts again

Cleaned up DictionaryTable so theres only one selection type now

Cleaned up dictionary permissions

Removed aerie-phoenix-wordmark

Disable seqn and seqjson exports when there is no sequence

Added styles to the selected command section

Converted fswCommandArgDefault to use a switch

Renamed parcel to parameter dictionaries

Some more cleanup

Fixed toggling by clicking a row on the parcel page

Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

Added st-typography-body to the no selected command text

Fixed an issue where the delete button was showing on dictionaries on the parcel page

Added some hint text to the Selected Command panel when there isn't a parcel selected

Fixed an issue with the selected command panel wasn't propagating changes

Removed the shared dictionary permission for creation

Changed permissions for the dictionary create button to check every upload permission

Fixed one more permission issue and added a div to support selected command testing

Added back in the missing seq adaptation name field

Removed unnecessary part of a regex

Fixed some styling issues with the selected command panel

Fixed an issue where the upload file button wasn't being disabled after
upload

allow for panel body to show up when SeqJson editor is "hidden"

Cleaned up the sequence store and removed all the parcel and parcel id weirdness

Fixed an issue when creating a new parcel is another user adds one it reset changes

Fixed an issue where parcels never became saveable

Moved to a more general seq editor and adaptation

Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson

Renamed new-sequence-editor dir to sequence-editor

Fixed a whole bunch of broken imports

Added a helper function to get sequence adaptation globals

---------

Co-authored-by: Bryan <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>
cohansen added a commit that referenced this pull request Jul 16, 2024
* Moved to a more general seq editor and adaptation

* Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time

* Fix plan metadata name input reset on snapshot preview (#1358)

* fix table action icons staying disabled when no longer in snapshot preview
* make table components less plan specific

* Add plan JSON export (#1357)

* add plan JSON export

* Hide plan export button (#1374)

* Release v2.15.0 (#1377)

Co-authored-by: joswig <[email protected]>

* Cleanup NumEditor and convert value to a number

Added tooltip support for repeat args

Removed utils.ts again

Cleaned up DictionaryTable so theres only one selection type now

Cleaned up dictionary permissions

Removed aerie-phoenix-wordmark

Disable seqn and seqjson exports when there is no sequence

Added styles to the selected command section

Converted fswCommandArgDefault to use a switch

Renamed parcel to parameter dictionaries

Some more cleanup

Fixed toggling by clicking a row on the parcel page

Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

Added st-typography-body to the no selected command text

Fixed an issue where the delete button was showing on dictionaries on the parcel page

Added some hint text to the Selected Command panel when there isn't a parcel selected

Fixed an issue with the selected command panel wasn't propagating changes

Removed the shared dictionary permission for creation

Changed permissions for the dictionary create button to check every upload permission

Fixed one more permission issue and added a div to support selected command testing

Added back in the missing seq adaptation name field

Removed unnecessary part of a regex

Fixed some styling issues with the selected command panel

Fixed an issue where the upload file button wasn't being disabled after
upload

allow for panel body to show up when SeqJson editor is "hidden"

Cleaned up the sequence store and removed all the parcel and parcel id weirdness

Fixed an issue when creating a new parcel is another user adds one it reset changes

Fixed an issue where parcels never became saveable

Moved to a more general seq editor and adaptation

Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson

Renamed new-sequence-editor dir to sequence-editor

Fixed a whole bunch of broken imports

Added a helper function to get sequence adaptation globals

---------

Co-authored-by: Bryan <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>
cohansen added a commit that referenced this pull request Jul 17, 2024
* Cleanup NumEditor and convert value to a number

* Added tooltip support for repeat args

* Removed utils.ts again

* Cleaned up DictionaryTable so theres only one selection type now

* Cleaned up dictionary permissions

* Removed aerie-phoenix-wordmark

* Disable seqn and seqjson exports when there is no sequence

* Added styles to the selected command section

* Converted fswCommandArgDefault to use a switch

* Renamed parcel to parameter dictionaries

* Some more cleanup

* Fixed toggling by clicking a row on the parcel page

* Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

* Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

* Added st-typography-body to the no selected command text

* Fixed an issue where the delete button was showing on dictionaries on the parcel page

* Added some hint text to the Selected Command panel when there isn't a parcel selected

* Fixed an issue with the selected command panel wasn't propagating changes

* Removed the shared dictionary permission for creation

* Changed permissions for the dictionary create button to check every upload permission

* Fixed one more permission issue and added a div to support selected command testing

* Added back in the missing seq adaptation name field

* Removed unnecessary part of a regex

* Fixed some styling issues with the selected command panel

* Fixed an issue where the upload file button wasn't being disabled after
upload

* allow for panel body to show up when SeqJson editor is "hidden"

* Cleaned up the sequence store and removed all the parcel and parcel id weirdness

* Fixed an issue when creating a new parcel is another user adds one it reset changes

* Fixed an issue where parcels never became saveable

* Selected Command styling, fixes, range display

* Range display tweak

* NumEditor input validation fix

* Refactor

* Feature/remove sequence lang specifics (#1372)

* Moved to a more general seq editor and adaptation

* Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time

* Fix plan metadata name input reset on snapshot preview (#1358)

* fix table action icons staying disabled when no longer in snapshot preview
* make table components less plan specific

* Add plan JSON export (#1357)

* add plan JSON export

* Hide plan export button (#1374)

* Release v2.15.0 (#1377)

Co-authored-by: joswig <[email protected]>

* Cleanup NumEditor and convert value to a number

Added tooltip support for repeat args

Removed utils.ts again

Cleaned up DictionaryTable so theres only one selection type now

Cleaned up dictionary permissions

Removed aerie-phoenix-wordmark

Disable seqn and seqjson exports when there is no sequence

Added styles to the selected command section

Converted fswCommandArgDefault to use a switch

Renamed parcel to parameter dictionaries

Some more cleanup

Fixed toggling by clicking a row on the parcel page

Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

Added st-typography-body to the no selected command text

Fixed an issue where the delete button was showing on dictionaries on the parcel page

Added some hint text to the Selected Command panel when there isn't a parcel selected

Fixed an issue with the selected command panel wasn't propagating changes

Removed the shared dictionary permission for creation

Changed permissions for the dictionary create button to check every upload permission

Fixed one more permission issue and added a div to support selected command testing

Added back in the missing seq adaptation name field

Removed unnecessary part of a regex

Fixed some styling issues with the selected command panel

Fixed an issue where the upload file button wasn't being disabled after
upload

allow for panel body to show up when SeqJson editor is "hidden"

Cleaned up the sequence store and removed all the parcel and parcel id weirdness

Fixed an issue when creating a new parcel is another user adds one it reset changes

Fixed an issue where parcels never became saveable

Moved to a more general seq editor and adaptation

Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson

Renamed new-sequence-editor dir to sequence-editor

Fixed a whole bunch of broken imports

Added a helper function to get sequence adaptation globals

---------

Co-authored-by: Bryan <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>

* Fixed an issue where renaming the parcel and then saving wasn't setting parcelModified back to false

* Fixed some tests I broke

* Fixed all the to and from seq json unit tests

* Fixed an issue where the save button was flickering on the parcel page

* Removed unused var

* Added a max-width for the sequence editor tooltips

---------

Co-authored-by: bduran <[email protected]>
Co-authored-by: Aaron Plave <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* add plan JSON export
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
* Cleanup NumEditor and convert value to a number

* Added tooltip support for repeat args

* Removed utils.ts again

* Cleaned up DictionaryTable so theres only one selection type now

* Cleaned up dictionary permissions

* Removed aerie-phoenix-wordmark

* Disable seqn and seqjson exports when there is no sequence

* Added styles to the selected command section

* Converted fswCommandArgDefault to use a switch

* Renamed parcel to parameter dictionaries

* Some more cleanup

* Fixed toggling by clicking a row on the parcel page

* Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

* Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

* Added st-typography-body to the no selected command text

* Fixed an issue where the delete button was showing on dictionaries on the parcel page

* Added some hint text to the Selected Command panel when there isn't a parcel selected

* Fixed an issue with the selected command panel wasn't propagating changes

* Removed the shared dictionary permission for creation

* Changed permissions for the dictionary create button to check every upload permission

* Fixed one more permission issue and added a div to support selected command testing

* Added back in the missing seq adaptation name field

* Removed unnecessary part of a regex

* Fixed some styling issues with the selected command panel

* Fixed an issue where the upload file button wasn't being disabled after
upload

* allow for panel body to show up when SeqJson editor is "hidden"

* Cleaned up the sequence store and removed all the parcel and parcel id weirdness

* Fixed an issue when creating a new parcel is another user adds one it reset changes

* Fixed an issue where parcels never became saveable

* Selected Command styling, fixes, range display

* Range display tweak

* NumEditor input validation fix

* Refactor

* Feature/remove sequence lang specifics (#1372)

* Moved to a more general seq editor and adaptation

* Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time

* Fix plan metadata name input reset on snapshot preview (#1358)

* fix table action icons staying disabled when no longer in snapshot preview
* make table components less plan specific

* Add plan JSON export (#1357)

* add plan JSON export

* Hide plan export button (#1374)

* Release v2.15.0 (#1377)

Co-authored-by: joswig <[email protected]>

* Cleanup NumEditor and convert value to a number

Added tooltip support for repeat args

Removed utils.ts again

Cleaned up DictionaryTable so theres only one selection type now

Cleaned up dictionary permissions

Removed aerie-phoenix-wordmark

Disable seqn and seqjson exports when there is no sequence

Added styles to the selected command section

Converted fswCommandArgDefault to use a switch

Renamed parcel to parameter dictionaries

Some more cleanup

Fixed toggling by clicking a row on the parcel page

Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

Added st-typography-body to the no selected command text

Fixed an issue where the delete button was showing on dictionaries on the parcel page

Added some hint text to the Selected Command panel when there isn't a parcel selected

Fixed an issue with the selected command panel wasn't propagating changes

Removed the shared dictionary permission for creation

Changed permissions for the dictionary create button to check every upload permission

Fixed one more permission issue and added a div to support selected command testing

Added back in the missing seq adaptation name field

Removed unnecessary part of a regex

Fixed some styling issues with the selected command panel

Fixed an issue where the upload file button wasn't being disabled after
upload

allow for panel body to show up when SeqJson editor is "hidden"

Cleaned up the sequence store and removed all the parcel and parcel id weirdness

Fixed an issue when creating a new parcel is another user adds one it reset changes

Fixed an issue where parcels never became saveable

Moved to a more general seq editor and adaptation

Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson

Renamed new-sequence-editor dir to sequence-editor

Fixed a whole bunch of broken imports

Added a helper function to get sequence adaptation globals

---------

Co-authored-by: Bryan <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>

* Fixed an issue where renaming the parcel and then saving wasn't setting parcelModified back to false

* Fixed some tests I broke

* Fixed all the to and from seq json unit tests

* Fixed an issue where the save button was flickering on the parcel page

* Removed unused var

* Added a max-width for the sequence editor tooltips

---------

Co-authored-by: bduran <[email protected]>
Co-authored-by: Aaron Plave <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* add plan JSON export
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
* Cleanup NumEditor and convert value to a number

* Added tooltip support for repeat args

* Removed utils.ts again

* Cleaned up DictionaryTable so theres only one selection type now

* Cleaned up dictionary permissions

* Removed aerie-phoenix-wordmark

* Disable seqn and seqjson exports when there is no sequence

* Added styles to the selected command section

* Converted fswCommandArgDefault to use a switch

* Renamed parcel to parameter dictionaries

* Some more cleanup

* Fixed toggling by clicking a row on the parcel page

* Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

* Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

* Added st-typography-body to the no selected command text

* Fixed an issue where the delete button was showing on dictionaries on the parcel page

* Added some hint text to the Selected Command panel when there isn't a parcel selected

* Fixed an issue with the selected command panel wasn't propagating changes

* Removed the shared dictionary permission for creation

* Changed permissions for the dictionary create button to check every upload permission

* Fixed one more permission issue and added a div to support selected command testing

* Added back in the missing seq adaptation name field

* Removed unnecessary part of a regex

* Fixed some styling issues with the selected command panel

* Fixed an issue where the upload file button wasn't being disabled after
upload

* allow for panel body to show up when SeqJson editor is "hidden"

* Cleaned up the sequence store and removed all the parcel and parcel id weirdness

* Fixed an issue when creating a new parcel is another user adds one it reset changes

* Fixed an issue where parcels never became saveable

* Selected Command styling, fixes, range display

* Range display tweak

* NumEditor input validation fix

* Refactor

* Feature/remove sequence lang specifics (#1372)

* Moved to a more general seq editor and adaptation

* Fixed an issue where you could save a parcel without a name, fixed being able to upload multiple dictionaries at a time

* Fix plan metadata name input reset on snapshot preview (#1358)

* fix table action icons staying disabled when no longer in snapshot preview
* make table components less plan specific

* Add plan JSON export (#1357)

* add plan JSON export

* Hide plan export button (#1374)

* Release v2.15.0 (#1377)

Co-authored-by: joswig <[email protected]>

* Cleanup NumEditor and convert value to a number

Added tooltip support for repeat args

Removed utils.ts again

Cleaned up DictionaryTable so theres only one selection type now

Cleaned up dictionary permissions

Removed aerie-phoenix-wordmark

Disable seqn and seqjson exports when there is no sequence

Added styles to the selected command section

Converted fswCommandArgDefault to use a switch

Renamed parcel to parameter dictionaries

Some more cleanup

Fixed toggling by clicking a row on the parcel page

Fixed an issue where changing selected parameter dictionaries for a parcel wasn't enabling the save button

Fixed an issue where selecting remove in the command editor panel didn't remove the broken argument

Added st-typography-body to the no selected command text

Fixed an issue where the delete button was showing on dictionaries on the parcel page

Added some hint text to the Selected Command panel when there isn't a parcel selected

Fixed an issue with the selected command panel wasn't propagating changes

Removed the shared dictionary permission for creation

Changed permissions for the dictionary create button to check every upload permission

Fixed one more permission issue and added a div to support selected command testing

Added back in the missing seq adaptation name field

Removed unnecessary part of a regex

Fixed some styling issues with the selected command panel

Fixed an issue where the upload file button wasn't being disabled after
upload

allow for panel body to show up when SeqJson editor is "hidden"

Cleaned up the sequence store and removed all the parcel and parcel id weirdness

Fixed an issue when creating a new parcel is another user adds one it reset changes

Fixed an issue where parcels never became saveable

Moved to a more general seq editor and adaptation

Added more generic calling of to output and from input, tried to remove most of the referencs to seqjson

Renamed new-sequence-editor dir to sequence-editor

Fixed a whole bunch of broken imports

Added a helper function to get sequence adaptation globals

---------

Co-authored-by: Bryan <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>

* Fixed an issue where renaming the parcel and then saving wasn't setting parcelModified back to false

* Fixed some tests I broke

* Fixed all the to and from seq json unit tests

* Fixed an issue where the save button was flickering on the parcel page

* Removed unused var

* Added a max-width for the sequence editor tooltips

---------

Co-authored-by: bduran <[email protected]>
Co-authored-by: Aaron Plave <[email protected]>
Co-authored-by: Chet Joswig <[email protected]>
Co-authored-by: joswig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants