-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DB Migration docs #201
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looking good @Mythicaeda - just one change to an example command here (see related notes on the aerie PR here )
@@ -23,129 +28,57 @@ Alternatively, you can add the script to your `PATH` and run it from anywhere wi | |||
export PATH="$HOME/path/to/deployment:$PATH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment belongs on line 22 above, I can't put it there because Github...
This command python aerie_db_migration.py
is no longer a valid call to the script due to the newly added subcommands - we should replace it with the new minimum command. Since I think some values from the env file are required, that would be something like aerie_db_migration.py migrate -e .env
, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-e .env
isn't required, but the subcommand is. I've updated the docs to reflect this.
- Move old docs to unlisted subpage
bae5502
to
d1ed28a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, approved! Let's hold off on merging this until next release for least confusion, I will merge it at release time.
Docs PR for NASA-AMMOS/aerie#1617.
Moves the old docs to an unlisted subpage that is linked from the updated docs (and links back to the updated docs).