Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfixes: Missed name change and permissions nuance #82

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Hotfixes: Missed name change and permissions nuance #82

merged 5 commits into from
Sep 13, 2023

Conversation

cartermak
Copy link
Member

@cartermak cartermak commented Sep 12, 2023 •
edited
Loading

Two bug fixes found after the 2.0.0 release:

  • Fixes a lingering reference to Activity.parameters (since replaced with Activity.arguments to align with Aerie conventions) and correct the fields in the data class and query. Adds a test that exercises the --full-args option for plans download.
  • Removes PK plan_id from activity updates because even "aerie_admin" doesn't have permissions. Updates corresponding unit test and tested against an Aerie instance.

@cartermak cartermak added the bug Something isn't working label Sep 12, 2023
@cartermak cartermak self-assigned this Sep 12, 2023
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 00:43 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Error
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 15:26 — with GitHub Actions Inactive
@cartermak cartermak had a problem deploying to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Failure
@cartermak cartermak had a problem deploying to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Failure
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:12 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:22 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:22 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:22 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:22 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:22 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:22 — with GitHub Actions Inactive
@cartermak cartermak force-pushed the hotfix--effective-arguments-bug branch from eff5394 to ef14c02 Compare September 12, 2023 16:29
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:29 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 16:30 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak temporarily deployed to integration-test-workflow September 12, 2023 22:59 — with GitHub Actions Inactive
@cartermak cartermak changed the title Hotfix: Bug in effective arguments Hotfixes: Missed name change and permissions nuance Sep 12, 2023
@cartermak cartermak merged commit 43ee527 into main Sep 13, 2023
@cartermak cartermak deleted the hotfix--effective-arguments-bug branch September 13, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mythicaeda Mythicaeda Mythicaeda approved these changes

Assignees

@cartermak cartermak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cartermak @Mythicaeda