Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/default activity directive name #139

Closed
wants to merge 18 commits into from

Conversation

bradNASA
Copy link
Collaborator

@bradNASA bradNASA commented Jun 6, 2024

When uploading a plan, if a name is not provided for a directive it remains blank when it's expected to use the type as the name. This one-liner fixes that.

cartermak and others added 18 commits October 19, 2023 17:38
* Update scheduling queries and unit tests to conform to Aerie v2.6 (#129)

* Updating scheduling module to work with Aerie 2.6

* Update to include a 2.6 banananation jar, and updated .env to use 2.6

* Refactor to replace deprecated datetime.utcnow() calls

* Removed banananation 2.2.0 jar

* Updated to use 2.6.0 instead of 2.2.0

* Updated aerie_client based on PR feedback

* Updating conftest to use v2.6.0

* Updated constraints queries to match v2.6.0 schema

* Updated aerie_host.is_auth_enabled()

* Updated constraints.py to remove unnecessary comments/add docstrings

* Removed upload_scheduling_goal wrapper function, as it is not being used and the same functionality is available with upload_scheduling_goals

* Documentation updates (#130)

* Updated pyproject.toml version to v2.4.0

---------

Co-authored-by: Carter Mak <[email protected]>
# Conflicts:
#	.env
#	.github/workflows/test.yml
#	tests/integration_tests/conftest.py
#	tests/integration_tests/files/models/banananation-2.2.0.jar
#	tests/integration_tests/files/models/banananation-2.6.0.jar
#	tests/integration_tests/files/models/banananation-2.8.0.jar
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA bradNASA temporarily deployed to integration-test-workflow June 6, 2024 00:37 — with GitHub Actions Inactive
@bradNASA
Copy link
Collaborator Author

bradNASA commented Jun 6, 2024

oops, I think this was on top of other unintended changes--probably a history rewrite thing

@bradNASA bradNASA closed this Jun 6, 2024
@bradNASA bradNASA deleted the fix/default-activity-directive-name branch June 9, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants