-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #61 - Adding tool tip to fieldname #97
Conversation
@aywaldron the solution looks good, but we also need to make sure it is backwards compatible. this blows up GUIs that don't use this new tag: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, falling back to the old rendering if display_name isn't set would be good so we don't break existing stuff.
Good point. Just pushed a fix to make it backward compatible. |
@jordanpadams @MJJoyce Is the build failing because of these changes, or something else? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks good to me. Please rebase the merge commit out before we merge and open a follow up ticket so this gets added to the documentation. Thanks!
Added
display_name
attribute toait-field
tag whichField.view()
uses to return the following dom structure:Added css class for making
name
bold.Resolves #61