Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #61 - Adding tool tip to fieldname #97

Merged
merged 2 commits into from
Nov 29, 2018
Merged

Issue #61 - Adding tool tip to fieldname #97

merged 2 commits into from
Nov 29, 2018

Conversation

aywaldron
Copy link
Contributor

@aywaldron aywaldron commented Nov 8, 2018

Added display_name attribute to ait-field tag which Field.view() uses to return the following dom structure:

<ait-field> 
    <name>[display_name]</name>
    <value>[value]</field>
</ait-field>

Added css class for making name bold.

Resolves #61

@aywaldron aywaldron requested review from a team as code owners November 8, 2018 20:40
@jordanpadams
Copy link
Contributor

@aywaldron the solution looks good, but we also need to make sure it is backwards compatible. this blows up GUIs that don't use this new tag:

screen shot 2018-11-08 at 3 32 57 pm

Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, falling back to the old rendering if display_name isn't set would be good so we don't break existing stuff.

@aywaldron
Copy link
Contributor Author

Good point. Just pushed a fix to make it backward compatible.

@aywaldron
Copy link
Contributor Author

@jordanpadams @MJJoyce Is the build failing because of these changes, or something else?

@aywaldron
Copy link
Contributor Author

aywaldron commented Nov 15, 2018

Tests pass for me locally.
screen shot 2018-11-15 at 2 26 41 pm

MJJoyce
MJJoyce previously approved these changes Nov 28, 2018
Copy link
Member

@MJJoyce MJJoyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me. Please rebase the merge commit out before we merge and open a follow up ticket so this gets added to the documentation. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants