-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #92: Update monitoring with notification throttling #93
+158
−4
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f9066bf
Issue #92: Update monitoring with notitication throttling
jordanpadams 9c43ca8
Issue #92 - Update limit monitoring with checks for lowering repeat n…
aywaldron f71570b
Issue #92 - Update limit monitoring with checks for lowering repeat n…
aywaldron b16b90c
Issue #92 - Allow for frequency notification option to not be specified
aywaldron 6dc359a
Issue #92 - Small refactoring of enable_monitoring function
aywaldron 051593f
Issue #92 - Adding script for testing new notification options
aywaldron 6359e8b
Issue #92 - Setting better default notif option values.
aywaldron 80b911e
Issue #92 - Refactoring and adding -default flag to script for testin…
aywaldron ab1c39c
Issue #92 - Updating comments on expected notifications
aywaldron 449ce34
Issue #92 - Changing print statements to log.info
aywaldron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Issue #92 - Small refactoring of enable_monitoring function
commit 6dc359adf7cf2ea1bc7099a17b97c8c2a46db6e2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and set sane defaults here. Otherwise the behavior could end up being a bit off. For instance, as is the
notif_thrshld
variable ends up set asNone
if my config doesn't have a value fornotifications.options.threshold
and I enable monitoring.You can do this with a one line for both of these values