Issue #82 - Add commands without subsystem to default subsystem group #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands are added to a default subsystem group on the frontend during command dictionary parsing so that components that expect commands to be grouped as such function as expected. Specifically, this allows the CommandSearch object to get commands grouped as expected for display. Since the subsystem attribute isn't required this means that the CommandSearch component will default to all commands showing up under this default subsystem header instead of not at all.
|
On second thought, I'm ok with this. The original dictionary is intact and this update is making sure that our "by subsystem" split of the data has all of the commands present in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands are added to a default subsystem group on the frontend
during command dictionary parsing so that components that expect
commands to be grouped as such function as expected. Specifically, this
allows the CommandSearch object to get commands grouped as expected for
display. Since the subsystem attribute isn't required this means that the
CommandSearch component will default to all commands showing up under
this default subsystem header instead of not at all.
Resolve #82