Issue #25 - Update Plot time label and Search time handling #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the plot x-axis label to `Time` instead of `Time (UTC)`. This field isn't necessarily UTC since users can specify a custom field in their telemetry that indicates time. The more generic label should help avoid confusion here. Update time handling in MnemonicSearch to explicitly use UTC time instead of the default (which was changed in #3). In the future we should attempt to update the handling of this so that the Clock mode dictates which time format is used.
lorsposto
previously approved these changes
May 8, 2018
lorsposto
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the plot x-axis label to
Timeinstead ofTime (UTC). Thisfield isn't necessarily UTC since users can specify a custom field in
their telemetry that indicates time. The more generic label should help
avoid confusion here.
Update time handling in MnemonicSearch to explicitly use UTC time
instead of the default (which was changed in #3). In the future we
should attempt to update the handling of this so that the Clock mode
dictates which time format is used.
Resolve #25