Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry and pre-commit #235

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Add poetry and pre-commit #235

merged 3 commits into from
Dec 14, 2022

Conversation

jasonmlkang
Copy link
Contributor

Changes

  • Added poetry
  • Added pre-commit
  • Fixed linter issue related to pre-commit check

Refs

Original issue #231

@jasonmlkang jasonmlkang requested review from MJJoyce and nttoole August 3, 2022 19:59
@jasonmlkang jasonmlkang requested review from a team as code owners August 3, 2022 19:59
@nttoole
Copy link
Contributor

nttoole commented Aug 5, 2022

@jasonmlkang I tried testing the GUI but Python complained:

2022-08-05T13:57:59.039 | ERROR    | <class 'ModuleNotFoundError'> creating plugin 0: No module named 'ait.gui'
2022-08-05T13:57:59.040 | WARNING  | No valid plugin configurations found. No plugins will be added.

For my environment:

  1. I am creating a venv via: python3 -m venv venv
    ...and then activating it via: source venv/bin/activate.csh

  2. I then git-cloned and poetry-installed the two AIT projects.
    No issues when running poetry on those.

  3. After that I set AIT_CONFIG and then added the GUI plugin config to it.

  4. Finally I ran: ./AIT-Core//ait/core/bin/ait_server.py

This is similar to issues I was having before when poetry and pip were mixed, and ait.core module could not be found.
Anyhoot, the environment setup is relatively bare-bones (vs Conga, etc), so I would expect it to work.

Could you please give it a whirl and see what might need to be resolved? Thanks

@nttoole
Copy link
Contributor

nttoole commented Aug 5, 2022

Not sure if this info helps:

[venv] MT-202661{nttoole}% ls ./venv/lib/python3.7/site-packages/ait*
ait/                            ait_core-2.3.5.dist-info/       ait_core.pth                    ait_gui.pth 
ait_core-2.3.5-py3.7-nspkg.pth  ait_core-2.3.6rc1.dist-info/    ait_gui-2.3.2rc1.dist-info/    

[venv] MT-202661{nttoole}% ls ./venv/lib/python3.7/site-packages/ait/
core

@MJJoyce
Copy link
Member

MJJoyce commented Dec 14, 2022

Merging this as is and will address other packaging updates in follow on tickets. Looks like this is working fine but could be wrong. Willing to let this break stuff temporarily so work can carry on.

Thanks @jasonmlkang!!

@MJJoyce MJJoyce merged commit ea11347 into master Dec 14, 2022
@MJJoyce MJJoyce deleted the 231-convert-to-poetry branch December 14, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants