Issue #200 - Properly decode received log messages in GUI plugin #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the process_log_msg() helper to properly decode the received 0MQ message from bytes into a str prior to passing it off to log.parseSyslog. This necessary change was overlooked in our testing for the new 0MQ send / recv call updates in Core / GUI. Resolve #200
|
@MJJoyce I was hoping this was a fix to NASA-AMMOS/AIT-Core#266 but I 'spose its not. |
|
No, different issue sadly. Or, at least, I'm not aware of it fixing that as well =D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the process_log_msg() helper to properly decode the received 0MQ
message from bytes into a str prior to passing it off to
log.parseSyslog. This necessary change was overlooked in our testing for
the new 0MQ send / recv call updates in Core / GUI.
Resolve #200