-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #105_kkallas - Rework of Backend/Frontend telemetry processing #170
Conversation
Futabay
commented
May 14, 2020
- Updated dict.iteritems to dict.items (Update dict.iteritems() (Py2) to dict.items() (Py3) #169)
- Added dntoeu plot option
- Added getPacket utility method
- Update tlm/realtime route to send packet to front end in JSON format - Update TelemetryStream on frontend to parse JSON formatted packet - Update plotting on frontend to work with JSON formatted packet - Update getting field values from packet on frontend to work with JSON
82d1ecd
to
4a5bf0e
Compare
Noticed when testing a bit that it doesn't look like Derived values are making it to the frontend / working at the moment.
That's in our default tlm.yaml. If I add that as a field I'm not seeing anything get displayed for it. We'll have to dig into the code creating a clean diff and see if those are getting picked up. I'm fine with handling that in a follow up ticket though. |
I will investigate that. Would you mind creating the following up ticket? |
ait/gui/static/js/ait/util.js
Outdated
* Returns DN to EU value if it exists unless the `raw` parameter is true, | ||
* otherwise return raw value. | ||
*/ | ||
function getPacket (data, raw=false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that the logic below is wrong, but couldn't we simplify a bit?
// Default to the raw value since it will always be avilable
let value = data['raw']
// If raw==false and a DN to EU value exists, grab that
if (!raw && data['dntoeu']) {
value = data['dntoeu']
}
return value
👍 Merging as is. We can open follow up tickets as needed. Thanks for getting it integrated! |