Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #105_kkallas - Rework of Backend/Frontend telemetry processing #170

Merged
merged 34 commits into from
May 26, 2020

Conversation

Futabay
Copy link
Contributor

@Futabay Futabay commented May 14, 2020

@Futabay Futabay requested review from a team as code owners May 14, 2020 18:27
aywaldron and others added 28 commits May 19, 2020 10:00
- Update tlm/realtime route to send packet to front end in JSON format
- Update TelemetryStream on frontend to parse JSON formatted packet
- Update plotting on frontend to work with JSON formatted packet
- Update getting field values from packet on frontend to work with JSON
@Futabay Futabay force-pushed the issue-105_kkallas branch from 82d1ecd to 4a5bf0e Compare May 19, 2020 17:02
@MJJoyce
Copy link
Member

MJJoyce commented May 21, 2020

Noticed when testing a bit that it doesn't look like Derived values are making it to the frontend / working at the moment.

  derivations:
    - !Derivation 
      name: Volt_Diff
      desc: Difference between Voltage_A and Voltage_B
      equation: Difference(Voltage_A, Voltage_B)
      units: Volts
      type: MSB_U16

That's in our default tlm.yaml. If I add that as a field I'm not seeing anything get displayed for it. We'll have to dig into the code creating a clean diff and see if those are getting picked up. I'm fine with handling that in a follow up ticket though.

@Futabay
Copy link
Contributor Author

Futabay commented May 22, 2020

I will investigate that. Would you mind creating the following up ticket?

* Returns DN to EU value if it exists unless the `raw` parameter is true,
* otherwise return raw value.
*/
function getPacket (data, raw=false) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that the logic below is wrong, but couldn't we simplify a bit?

// Default to the raw value since it will always be avilable
let value = data['raw']

// If raw==false and a DN to EU value exists, grab that
if (!raw && data['dntoeu']) {
    value = data['dntoeu']
}

return value

@MJJoyce MJJoyce merged commit 76437ba into master May 26, 2020
@MJJoyce
Copy link
Member

MJJoyce commented May 26, 2020

👍 Merging as is. We can open follow up tickets as needed. Thanks for getting it integrated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants