Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clock format toggling doesn't rotate through options as expected #94

Closed
MJJoyce opened this issue Nov 3, 2018 · 0 comments
Closed

Clock format toggling doesn't rotate through options as expected #94

MJJoyce opened this issue Nov 3, 2018 · 0 comments
Assignees

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Nov 3, 2018

Expected behavior:

Clicking the time format indicator should cycle the clock through the available time format options:
GPS -> UTC -> Local time -> GPS

Current behavior:

This works as expected until we get into local time. When local time is displayed no time format information is shown so we're not able to cycle back to GPS time. Instead, we end up clicking on the time which cycles us between 12/24 hour time.

aywaldron added a commit that referenced this issue Nov 7, 2018
…xpected

- added variable 'local' to Clock
- updated toggleTimeFormat to use new 'local' var
- updated function tz in format.js to return 'Local Time' string
- updated test_clock.js to test toggling between local time
- added fsevents 1.2.4 to package.json
aywaldron added a commit that referenced this issue Nov 7, 2018
…xpected

- added variable 'local' to Clock
- updated toggleTimeFormat to use new 'local' var
- updated function tz in format.js to return 'Local Time' string
- updated test_clock.js to test toggling between local time
- added fsevents 1.2.4 to package.json
- updated package-lock.json to be insync with package.json
jordanpadams added a commit that referenced this issue Nov 8, 2018
Issue #94 - Clock format toggling doesn't rotate through options as expected
aywaldron added a commit that referenced this issue Nov 29, 2018
…xpected

- added variable 'local' to Clock
- updated toggleTimeFormat to use new 'local' var
- updated function tz in format.js to return 'Local Time' string
- updated test_clock.js to test toggling between local time
- added fsevents 1.2.4 to package.json
- updated package-lock.json to be insync with package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants