Better handle KeyboardInterrupts in optional service greenlets #80
Assignees
Comments
MJJoyce
added a commit
that referenced
this issue
Jul 12, 2018
Add optional data archiving support. Users can enable data archiving via ait.gui.enable_data_archiving() prior to calling ait.gui.wait(). By default InfluxDB will be used but an optional argument can be set when calling enable_data_archiving() to choose a different class. Update greenlet handling for monitoring and data archive tasks so that exits via Ctrl-C are cleaner. Greenlet functions are now wrapped in gevent.util.wrap_errors so that KeyboardInterrupt exceptions are returned instead of raised. This allows us to avoid stack traces being printed when killing the GUI. Greenlet tracking has been changed from individual global variables to a list of greenlet instances. Clean up code has been updated with this change as well. The ait.gui.wait function has been updated to use gevent.joinall if one or more of the optional services (data archiving or telemetry monitoring at the moment) are in use. This gives us a bit more control over how we handle greenlets that have returned and how exceptions are raised. If the optional services aren't being used we default to gevent.wait instead.
lorsposto
pushed a commit
that referenced
this issue
Jul 16, 2018
* Issue #79 and #80 - Data archiving and better interrupt handling Add optional data archiving support. Users can enable data archiving via ait.gui.enable_data_archiving() prior to calling ait.gui.wait(). By default InfluxDB will be used but an optional argument can be set when calling enable_data_archiving() to choose a different class. Update greenlet handling for monitoring and data archive tasks so that exits via Ctrl-C are cleaner. Greenlet functions are now wrapped in gevent.util.wrap_errors so that KeyboardInterrupt exceptions are returned instead of raised. This allows us to avoid stack traces being printed when killing the GUI. Greenlet tracking has been changed from individual global variables to a list of greenlet instances. Clean up code has been updated with this change as well. The ait.gui.wait function has been updated to use gevent.joinall if one or more of the optional services (data archiving or telemetry monitoring at the moment) are in use. This gives us a bit more control over how we handle greenlets that have returned and how exceptions are raised. If the optional services aren't being used we default to gevent.wait instead. * - Fix except block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our current implementation for the telemetry monitoring and data archiving (being developed in #79) services doesn't handle KeyboardInterrupt exceptions with the most grace. If one of the services is active when the interrupt is received a stack trace is dumped by the greenlet before the services shutdown. As such, the logs are full of stack traces / errors even when the GUI is shut down nominally and this isn't particularly user friendly.
It would be great if we could handle this in a cleaner way.
The text was updated successfully, but these errors were encountered: