Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mnemonic search fails due to missing limits options #6

Closed
MJJoyce opened this issue Apr 10, 2018 · 0 comments
Closed

Mnemonic search fails due to missing limits options #6

MJJoyce opened this issue Apr 10, 2018 · 0 comments
Assignees
@MJJoyce

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Apr 10, 2018

The mnemonic search result code breaks if some optional settings in the limits config aren't present. The check to handle this [1] is not catching the missing option and this results in attempts to access a member of undefined further down the code.

[1] https://github.jpl.nasa.gov/bliss/bliss-gui/blob/master/bliss/gui/static/js/bliss/gui/Search.js#L206
@MJJoyce MJJoyce self-assigned this Apr 10, 2018
MJJoyce added a commit that referenced this issue Apr 10, 2018
@MJJoyce
Issue #6 - Fix membership check in search limit formatting
45d5a6b
@MJJoyce MJJoyce mentioned this issue Apr 10, 2018
Merged
MJJoyce added a commit that referenced this issue Apr 10, 2018
@MJJoyce
Merge pull request #8 from NASA-AMMOS/issue-6
7303230 
Issue #6 - Fix membership check in search limit formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MJJoyce MJJoyce

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MJJoyce