Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate script execution from UI #20

Closed
MJJoyce opened this issue Apr 21, 2018 · 0 comments
Closed

Duplicate script execution from UI #20

MJJoyce opened this issue Apr 21, 2018 · 0 comments
Assignees

Comments

@MJJoyce
Copy link
Member

MJJoyce commented Apr 21, 2018

Ran into an issue with the monitoring UI where two instances of the same script executed when clicking the run button from the script control widget. The only way I could duplicate this was by double clicking the run button quickly before events propagated from the backend to the frontend and disabled the button functionality.

We should update 2 things on this. First, the backend should prevent attempts at running a script when another script is executing. This is arguably more useful to avoid two people from trying to run scripts and overlapping, but it also solves the encountered problem. Second, the execution control should be more intelligent about state tracking and preventing duplicate reactions. At the minimum, this should be on the script execute button.

@MJJoyce MJJoyce self-assigned this Apr 21, 2018
MJJoyce added a commit that referenced this issue Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant