Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make port configurable for GUI plugin #110

Closed
aywaldron opened this issue Jun 28, 2019 · 0 comments
Closed

Make port configurable for GUI plugin #110

aywaldron opened this issue Jun 28, 2019 · 0 comments

Comments

@aywaldron
Copy link
Contributor

Configuration parameter for AITGUIPlugin should be added for the port it runs on and incorporated into code in initializer:

AIT-GUI/ait/gui/__init__.py

Line 219 in 83d986b

def init(self, host=None, port=8080):

@aywaldron aywaldron changed the title Make port configurable in GUI plugin config Make port configurable for GUI plugin Jun 28, 2019
robschneider16 pushed a commit to robschneider16/AIT-GUI that referenced this issue Aug 6, 2019
Issue NASA-AMMOS#110 - Made GUI port optionally configurable
f75693d 
Instead of defaulting to port 8080, the ait gui should now look at the
ait config and pull the defined gui.port number from there if its defined.
If it is not defined, then it will use the default of 8080. All of which
gets overwritten if the user provided a port number to the init method
robschneider16 pushed a commit to robschneider16/AIT-GUI that referenced this issue Aug 13, 2019
Issue NASA-AMMOS#110 - Moved gui port kwarg to plugin init
39d0e4b 
Action requested from the PR review. Moved the port argument to the
plugin class init as a kwarg with a default to port 8080. Kwarg gets
populated based on whats defined in config.yaml.
robschneider16 pushed a commit to robschneider16/AIT-GUI that referenced this issue Aug 13, 2019
Issue NASA-AMMOS#110 - Changed AIT gui kwargs to attributes
d7c57f2 
Instead of passing in the values to the GUIs self.init method,
the init method will see if the plugin has the port and host items
defined as attributes.
robschneider16 pushed a commit to robschneider16/AIT-GUI that referenced this issue Aug 20, 2019
Issue NASA-AMMOS#110 - Use getadder for GUI init port & host
0d61967
robschneider16 pushed a commit to robschneider16/AIT-GUI that referenced this issue Aug 23, 2019
Issue NASA-AMMOS#110 - Fixed typo in host and port
a96cb98
MJJoyce added a commit that referenced this issue Aug 23, 2019
@MJJoyce
Merge pull request #120 from robschneider16/issue-110-gui-port-config
e46f882 
Issue #110 - Made GUI port optionally configurable
@MJJoyce MJJoyce closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MJJoyce @aywaldron