Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #467 - Add baseline GH Actions build #471

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Issue #467 - Add baseline GH Actions build #471

merged 1 commit into from
Dec 21, 2022

Conversation

MJJoyce
Copy link
Member

@MJJoyce MJJoyce commented Dec 20, 2022

Add a default build for any push to master or pull request that runs
the full tox build. This includes the test suite for all supported
python versions, the docs build, and the linting pipeline.

This is sufficient for a first pass but there are a couple of things we
might want to poke at. I could not get actions/setup-python caching of
poetry dependencies to work with tox-gh-actions. The lint run kept
failing because it couldn't find pre-commit even though it seemed to
have been installed properly. Should poke at this in a follow on ticket.

Would also be good to get a better build running to test package
deployment and the like. Bundling everything up and shipping it off to
test.pypi would be great. I'd also like to get a release build
integrated so we aren't manually doing that. Automatic CHANGELOG updates
after a push to master or PR merge would also be great.

Resolve #467

@MJJoyce MJJoyce requested review from a team as code owners December 20, 2022 17:25
@MJJoyce
Copy link
Member Author

MJJoyce commented Dec 20, 2022

See here for an example build using this workflow

Add a default build for any push to master or pull request that runs
the full `tox` build. This includes the test suite for all supported
python versions, the docs build, and the linting pipeline.

This is sufficient for a first pass but there are a couple of things we
might want to poke at. I could not get `actions/setup-python` caching of
poetry dependencies to work with `tox-gh-actions`. The lint run kept
failing because it couldn't find `pre-commit` even though it seemed to
have been installed properly. Should poke at this in a follow on ticket.

Would also be good to get a better build running to test package
deployment and the like. Bundling everything up and shipping it off to
test.pypi would be great. I'd also like to get a release build
integrated so we aren't manually doing that. Automatic CHANGELOG updates
after a push to master or PR merge would also be great.

Resolve #467
@MJJoyce MJJoyce merged commit 4be14d4 into master Dec 21, 2022
@MJJoyce MJJoyce deleted the issue-467 branch December 21, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate testing with GH Actions
2 participants