STYLE: Rename _GetImageViewFromArray to GetImageViewFromContiguousArray

Aims to clarify the difference between the C++ `itk::PyBuffer` member function
(which only supports contiguous arrays as input) and the Python method
`itkPyBuffer.GetImageViewFromArray` (which supports *both* contiguous and
non-contiguous arrays).

This commit also removes the leading underscore, as identifiers beginning with
an underscore, followed by an uppercase letter are reserved by the C++ standard.

Follow-up to pull request InsightSoftwareConsortium#4888
commit b769b81
"BUG: PyBuffer _GetImageViewFromArray should reject non-contiguous buffer"

Modules/Bridge/NumPy/include/itkPyBuffer.h

@@ -73,10 +73,11 @@ class PyBuffer
   _GetArrayViewFromImage(ImageType * image);
 
   /**
-   * Get an ITK image from a Python array
+   * Get an ITK image from a contiguous Python array. Internal helper function for the implementation of
+   * `itkPyBuffer.GetImageViewFromArray`.
    */
   static OutputImagePointer
-  _GetImageViewFromArray(PyObject * arr, PyObject * shape, PyObject * numOfComponent);
+  GetImageViewFromContiguousArray(PyObject * arr, PyObject * shape, PyObject * numOfComponent);
 };
 
 } // namespace itk

Modules/Bridge/NumPy/include/itkPyBuffer.hxx

@@ -52,7 +52,7 @@ PyBuffer<TImage>::_GetArrayViewFromImage(ImageType * image)
 
 template <class TImage>
 auto
-PyBuffer<TImage>::_GetImageViewFromArray(PyObject * arr, PyObject * shape, PyObject * numOfComponent)
+PyBuffer<TImage>::GetImageViewFromContiguousArray(PyObject * arr, PyObject * shape, PyObject * numOfComponent)
   -> OutputImagePointer
 {
   Py_buffer pyBuffer{};

Modules/Bridge/NumPy/wrapping/PyBuffer.i.in

@@ -99,11 +99,11 @@
 
         if is_vector:
             if ndarr.flags['C_CONTIGUOUS']:
-                imgview = itkPyBuffer@PyBufferTypes@._GetImageViewFromArray(ndarr, ndarr.shape[-2::-1], ndarr.shape[-1])
+                imgview = itkPyBuffer@PyBufferTypes@.GetImageViewFromContiguousArray(ndarr, ndarr.shape[-2::-1], ndarr.shape[-1])
             else:
-                imgview = itkPyBuffer@PyBufferTypes@._GetImageViewFromArray(ndarr, ndarr.shape[-1:0:-1], ndarr.shape[0])
+                imgview = itkPyBuffer@PyBufferTypes@.GetImageViewFromContiguousArray(ndarr, ndarr.shape[-1:0:-1], ndarr.shape[0])
         else:
-            imgview = itkPyBuffer@PyBufferTypes@._GetImageViewFromArray(ndarr, ndarr.shape[::-1], 1)
+            imgview = itkPyBuffer@PyBufferTypes@.GetImageViewFromContiguousArray(ndarr, ndarr.shape[::-1], 1)
 
         # Keep a reference
         imgview._SetBase(ndarr)