Delete most of libmythservicecontracts #998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulmus-scott
force-pushed
the
servicecontracts
branch
2 times, most recently
from
e5161c1 to
2cfd9af
Compare
|
I don't know why removing the lines to link to libmythservicecontracts for the tests worked on my computer, but the GitHub Actions failed to link the tests. |
ulmus-scott
force-pushed
the
servicecontracts
branch
from
2cfd9af to
87c3cdb
Compare
This reverts commit 708ced3. Additionally delete mythtv/libs/libmythservicecontracts/test and remove references to it. add missing ')'s in libmythservicecontracts/CMakeLists.txt
libmythtv/HLS/httplivestream.h is only used by mythtranscode and I did not investigate what of it is used.
libmythservicecontracts no longer includes these files.
ulmus-scott
force-pushed
the
servicecontracts
branch
from
87c3cdb to
7674e3c
Compare
|
Thank you Scott, I will look at this. |
|
I have rebased and merged this into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed files were unused.
@bennettpeter The remaining files are in two groups, both related to HTTP servers:
services/rttiServices.h,datacontracts/enum.h, anddatacontracts/enumItem.h, which are used by libmythupnp. The backend log does show it is used, but I don't know what it is supposed to do or if it does anything.services/frontendServices.h,datacontracts/frontendActionList.h, anddatacontracts/frontendStatus.h, which are used by mythfrontend for MediaRenderer, which is an HTTP server. I have no idea why mythfrontend needs an HTTP server buthttp://mythfrontend-ip:6551/MythFE/GetActionTestfrom 107fcd2 generates a page.Checklist