Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MythMusic: Promote Fullscreen Vis to first menu item #1013

Merged
merged 1 commit into from
Jan 16, 2025
Merged

MythMusic: Promote Fullscreen Vis to first menu item #1013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions mythplugins/mythmusic/mythmusic/musiccommon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2286,12 +2286,6 @@ MythMenu* MusicCommon::createMainMenu(void)
{
menu->AddItem(tr("Switch To Tree View"));
}
else if (m_currentView == MV_PLAYLIST)
{
// menu->AddItem(tr("Playlist Editor")); // v33-
// this might be easier for new users to find / understand:
menu->AddItem(tr("Browse Music Library")); // v34+
}

QStringList screenList;
MythScreenType *screen = this;
Expand All @@ -2301,14 +2295,19 @@ MythMenu* MusicCommon::createMainMenu(void)
screen = qobject_cast<MusicCommon*>(screen)->m_parentScreen;
}

if (!screenList.contains("searchview") && !screenList.contains("streamview"))
menu->AddItem(tr("Search for Music"));

if (!screenList.contains("visualizerview"))
menu->AddItem(tr("Fullscreen Visualizer"));

if (!screenList.contains("lyricsview"))
menu->AddItem(tr("Lyrics"));
if (m_currentView == MV_PLAYLIST)
menu->AddItem(tr("Browse Music Library")); // v33- was "Playlist Editor"

if (m_currentView != MV_VISUALIZER) {
if (!screenList.contains("searchview") && !screenList.contains("streamview"))
menu->AddItem(tr("Search for Music"));

if (!screenList.contains("lyricsview"))
menu->AddItem(tr("Lyrics"));
}

menu->AddItem(tr("More Options"), nullptr, createSubMenu());

Expand Down
Loading