Add Call Endpoint #708
Add Call Endpoint #708
Conversation
arun-koshy
requested review from
huitseeker,
lxfind,
patrickkuo,
sblackshear,
stella3d,
666lcz and
oxade
|
Thanks for working on this! Can we also test passing by objects: https://github.com/MystenLabs/fastnft/blob/c7eb3f784cb7ea50bae21f4d0cc5b3956e7ab936/sui_programmability/framework/sources/ObjectBasics.move#L29? |
|
|
Please link an issue for unit tests |
|
@666lcz just in case this image was not clear, transferring objects via Move Call works! This is the curl request to do it yourself (it will hit the hosted version we are using for geniteam) curl --location --request POST 'http://3.229.149.13:5000/call' |
sui/src/rest_server.rs
Outdated
| let mut effects = Vec::new(); | ||
| for (obj, _) in transaction_effects.created { | ||
| let mut effect = HashMap::new(); | ||
| effect.insert("id".to_string(), obj.0.to_string()); | ||
| effect.insert("version".to_string(), format!("{:?}", obj.1)); | ||
| effect.insert("object_digest".to_string(), format!("{:?}", obj.2)); | ||
| for ((object_id, sequence_number, object_digest), _) in transaction_effects.created { | ||
| let effect = get_effect(wallet_context, object_id, sequence_number, object_digest) | ||
| .await | ||
| .map_err(|error| error)?; | ||
| effects.push(effect); | ||
| } |
There was a problem hiding this comment.
Nit: This is basically:
let effects = transaction_effects.created.map(|((object_id, sequence_number, object_digest), _)| {
get_effect(wallet_context, object_id, sequence_number, object_digest)
.await
.map_err(|error| error.into())
}.collect::<Result<Vec<_>,_>()?;But my point isn't the refactoring to combinators, it's about the use of an auxiliary private function (e.g. in this file) to not repeat this so many times.
What I'd love to see here and in other places is:
let effects = my_auxiliary_fn(some_kind_of_tx_effects).await?;if my_auxiliary_fn contains a for loop, I'll live :)
This is the fifth of a series of PR's that will implement the client service API described as part of the GDC Eng Deliverables
The endpoints that are included in this PR are:
Call: Execute a Move call transaction by calling the specified function in the module of the given package. Arguments are passed in and type will be inferred from function signature. Gas usage is capped by the gas_budget.
curl --location --request POST 'http://127.0.0.1:5000/call'
--header 'Content-Type: application/json'
--data-raw '{
"sender": "A7099E1F43A47D50488179D02E45DD63FFEAC8E9",
"packageObjectId": "0x2",
"module": "ObjectBasics",
"function": "create",
"args": [
100,
"0xA7099E1F43A47D50488179D02E45DD63FFEAC8E9"
],
"gasObjectId": "0F3A9F01B2C950DE335244EB8DA5DAD558F4038F",
"gasBudget": 2000
}'