[RPC API Improvement] - Add object type to transaction effect [SUI-62] #6636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkuo
reviewed
Dec 7, 2022
| @@ -316,7 +316,7 @@ pub enum MoveFunctionArgType { | |||
| Object(ObjectValueKind), | |||
| } | |||
|
|
|||
| #[derive(Serialize, Deserialize, Debug, JsonSchema)] | |||
| #[derive(Serialize, Deserialize, Debug)] | |||
There was a problem hiding this comment.
Shouldn't remove JsonSchema
| @@ -98,7 +99,7 @@ pub struct TemporaryStore<S> { | |||
| // into written directly. | |||
| written: BTreeMap<ObjectID, (SingleTxContext, Object, WriteKind)>, // Objects written | |||
| /// Objects actively deleted. | |||
| deleted: BTreeMap<ObjectID, (SingleTxContext, SequenceNumber, DeleteKind)>, | |||
| deleted: BTreeMap<ObjectID, (SingleTxContext, SequenceNumber, DeleteKind, Object)>, | |||
There was a problem hiding this comment.
we don't need to store the whole Object, which can be quite big, storing the type information should be enough
| @@ -449,6 +449,15 @@ impl Object { | |||
| (self.id(), self.version(), self.digest()) | |||
| } | |||
|
|
|||
| pub fn compute_object_type(&self) -> ObjectType{ | |||
There was a problem hiding this comment.
compute imply getting the object type need computation and could be expansive (e.g. compute digest), we can simply call this get_object_type
3 tasks
|
we cannot doen all actions properly |
|
nice |
|
Closing as stale! I believe, we have this change today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some initial changes towards the addition of object type to transaction effect.
@patrickkuo Please review my progress til now and confirm that I am on the right path.
I know that those changes don't pass all the test yet.