Add Debug module to move stdlib deps #660
Conversation
| @@ -0,0 +1,52 @@ | |||
| // Copyright (c) 2022, Mysten Labs, Inc. | |||
There was a problem hiding this comment.
Do we need this verifier pass? As long as we keep the Debug module out of genesis, any attempt to publish code with Debug's will fail with a linker error.
This perhaps isn't the best UX (although a linker error does give you the name of the module that the linker didn't find), but it does save authorities from needing to run a special verifier pass for this.
There was a problem hiding this comment.
I think we want to enable the use of Debug when running e2e tests though, like when running authority tests. So we need the module in the genesis.
There was a problem hiding this comment.
OK. Added it to denylist only under non-test mode. This should allow us to run tests with it.
Kept the changes in module_builder as they are useful.
| @@ -124,6 +129,30 @@ impl ModuleBuilder { | |||
| ) | |||
| } | |||
|
|
|||
| pub fn add_generic_function( | |||
There was a problem hiding this comment.
n00b question: why is this function defined but not used anywhere?
There was a problem hiding this comment.
This function was used in the first version of this PR. I have iterated and deleted the use. But this function is still useful utility to keep, so I didn't delete it.
Preserve order of batches
This PR imports the
Debugmodule from move stdlib nursery to our deps.Added a verifier to make sure we don't ship any call to Debug module when we publish them onchain.
This closes #652