crypto: simplify keystore #4828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Documentation
joyqvq
force-pushed
the
simplify-ks
branch
2 times, most recently
from
0191230 to
dd444a2
Compare
joyqvq
requested review from
randall-Mysten,
huitseeker and
patrickkuo
as code owners
joyqvq
requested review from
kchalkias
and removed request for
huitseeker and
randall-Mysten
kchalkias
reviewed
Sep 28, 2022
|
|
||
| // Sign the transaction | ||
| let signature = Signature::new(&create_game_call, &signer); | ||
| let signature = self |
There was a problem hiding this comment.
Let's change the comment above (everywhere). Use "Sign the transaction" vs "get the signer"
crates/test-utils/src/messages.rs
Outdated
| @@ -183,7 +180,9 @@ pub fn make_transactions_with_pre_genesis_objects( | |||
| /* gas_object_ref */ o2.compute_object_reference(), | |||
| MAX_GAS, | |||
| ); | |||
| let signature = Signature::new(&data, &signer); | |||
| let signature = keys | |||
| .sign(&o1.owner.get_owner_address().unwrap(), &data.to_bytes()) | |||
There was a problem hiding this comment.
I assume that at this stage unwrap() will always succeed. Can we add a comment, cause eventually we need to clean up all unwraps to avoid halting if an error occurs (unless we know unwrap() is safe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/n improvement to pave for modular crypto service, remove the signer method and use sign method in keystore directly. this helps extract keystore its own service