crypto: split crypto move lib #4653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyqvq
force-pushed
the
split-move-lib
branch
2 times, most recently
from
9dd3d80 to
62030f3
Compare
joyqvq
force-pushed
the
split-move-lib
branch
from
62030f3 to
3a21ce6
Compare
kchalkias
reviewed
Sep 20, 2022
| // Copyright (c) 2022, Mysten Labs, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| module sui::range_proof { |
There was a problem hiding this comment.
as we do algorithmic separation of the crypto modules in this PR, I'd call this bulletproofs instead of range_proof for consistency.
joyqvq
force-pushed
the
split-move-lib
branch
2 times, most recently
from
56510cb to
9e6dbc9
Compare
|
@kchalkias PTAL |
kchalkias
approved these changes
Oct 4, 2022
| // Copyright (c) 2022, Mysten Labs, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| module sui::bulletproof { |
There was a problem hiding this comment.
for consistency with the algorithm name, I'd use bulletproofs (with an "s")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting one crypto.move to four, no content update otherwise