-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors to BuildConfig
#21384
Merged
Merged
Refactors to BuildConfig
#21384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33d730a
to
6de7ccc
Compare
This was referenced Feb 28, 2025
6de7ccc
to
76386fe
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
stefan-mysten
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, modulo hoping the CI passes.
tzakian
approved these changes
Mar 5, 2025
76386fe
to
bddcf38
Compare
bddcf38
to
f52f2ed
Compare
4e569c8
to
d03f64d
Compare
f52f2ed
to
eeee9fd
Compare
mdgeorge4153
added a commit
that referenced
this pull request
Mar 8, 2025
…#21383) ## Description This PR adds support for implicit dependencies to the package management at the move layer. ## PR stack #21204 Add implicit Sui dependencies #21384 Refactors to BuildConfig #21383 Add support for implicits to move package management This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356 ## Test plan See `test_sources/implicits/README.md` for a description of the new snapshot tests --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
eeee9fd
to
bf334c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes
sui_move_build::BuildConfig::default
and makes other small changesPR stack
#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management
This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356
Test plan
Since no behavior should change, existing tests are sufficient
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.