Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors to BuildConfig #21384

Merged
merged 3 commits into from
Mar 9, 2025
Merged

Refactors to BuildConfig #21384

merged 3 commits into from
Mar 9, 2025

Conversation

mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Feb 28, 2025

Description

This removes sui_move_build::BuildConfig::default and makes other small changes

PR stack

#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management

This also depends on @stefan-mysten 's ongoing tree-shaking work in #21356

Test plan

Since no behavior should change, existing tests are sufficient


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/build-config-refactors branch from 6de7ccc to 76386fe Compare March 5, 2025 22:46
Copy link

vercel bot commented Mar 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2025 3:49pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Mar 9, 2025 3:49pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Mar 9, 2025 3:49pm

Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, modulo hoping the CI passes.

@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/build-config-refactors branch from 76386fe to bddcf38 Compare March 6, 2025 00:46
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 6, 2025 00:46 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/build-config-refactors branch from bddcf38 to f52f2ed Compare March 8, 2025 20:24
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 8, 2025 20:24 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 8, 2025 20:24 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 force-pushed the implicit-deps-on-move branch from 4e569c8 to d03f64d Compare March 8, 2025 20:56
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/build-config-refactors branch from f52f2ed to eeee9fd Compare March 8, 2025 20:56
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 8, 2025 20:56 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 8, 2025 20:56 — with GitHub Actions Inactive
Base automatically changed from implicit-deps-on-move to main March 8, 2025 21:27
mdgeorge4153 added a commit that referenced this pull request Mar 8, 2025
…#21383)

## Description 

This PR adds support for implicit dependencies to the package management at the move layer.

## PR stack

#21204 Add implicit Sui dependencies
#21384 Refactors to BuildConfig
#21383 Add support for implicits to move package management

This also depends on @stefan-mysten 's ongoing tree-shaking work in
#21356


## Test plan 

See `test_sources/implicits/README.md` for a description of the new
snapshot tests

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 9, 2025 15:46 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 marked this pull request as ready for review March 9, 2025 15:47
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env March 9, 2025 15:47 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 enabled auto-merge (squash) March 9, 2025 15:48
@mdgeorge4153 mdgeorge4153 merged commit 94dc4f8 into main Mar 9, 2025
67 of 82 checks passed
@mdgeorge4153 mdgeorge4153 deleted the mdgeorge/build-config-refactors branch March 9, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants