[typed store] iterators: migrate unbounded_iter callsites #21358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
db_iterators_interface_sf
branch
from
365ae8f to
d3b821a
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
db_iterators_interface_sf
branch
from
d3b821a to
0638df7
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
db_iterators_interface_sf
branch
from
0638df7 to
c10efb8
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
force-pushed
the
db_iterators_interface_sf
branch
from
c10efb8 to
c66b286
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
andll
approved these changes
Mar 9, 2025
There was a problem hiding this comment.
It seems that with this diff we changed bunch of functions to return SuiResult only to call .expect() on that result - it probably makes sense to instead just call '.expect()` right away where safe iterator is used, since storage error is not really actionable anywhere in sui.
But I'll leave it up to you.
phoenix-o
force-pushed
the
db_iterators_interface_sf
branch
from
c66b286 to
6e5f420
Compare
phoenix-o
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.