[CLI] Don't error if we cannot connect to active env #21116
Merged
+20
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
stefan-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
approved these changes
Feb 6, 2025
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Feb 6, 2025
## Description If the CLI cannot get the client that should connect to the active environment set in the config, it will error. This creates troubles for when you work on a local network and then stop it. Every client (and a few other) command will now error. This PR fixes this by relaxing a bit the condition. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed the bug when the CLI cannot connect to the active environment leading to an error on most commands. - [ ] Rust SDK:
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Feb 7, 2025
## Description If the CLI cannot get the client that should connect to the active environment set in the config, it will error. This creates troubles for when you work on a local network and then stop it. Every client (and a few other) command will now error. This PR fixes this by relaxing a bit the condition. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed the bug when the CLI cannot connect to the active environment leading to an error on most commands. - [ ] Rust SDK:
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Feb 7, 2025
## Description If the CLI cannot get the client that should connect to the active environment set in the config, it will error. This creates troubles for when you work on a local network and then stop it. Every client (and a few other) command will now error. This PR fixes this by relaxing a bit the condition. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed the bug when the CLI cannot connect to the active environment leading to an error on most commands. - [ ] Rust SDK:
stefan-mysten
added a commit
that referenced
this pull request
Feb 7, 2025
…1116) (#21124) ## Description If the CLI cannot get the client that should connect to the active environment set in the config, it will error. This creates troubles for when you work on a local network and then stop it. Every client (and a few other) command will now error. This PR fixes this by relaxing a bit the condition. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Fixed the bug when the CLI cannot connect to the active environment leading to an error on most commands. - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the CLI cannot get the client that should connect to the active environment set in the config, it will error. This creates troubles for when you work on a local network and then stop it. Every client (and a few other) command will now error.
This PR fixes this by relaxing a bit the condition.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.