Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exp-to-insta][11/n] Migrate move-stackless-bytecode and move-model #21111

Merged
merged 9 commits into from
Feb 11, 2025

Conversation

tnowacki
Copy link
Contributor

@tnowacki tnowacki commented Feb 6, 2025

Description

  • Migrate move-stackless-bytecode to use insta
  • Migrate move-model to use insta
  • Remove move-prover-test-utils

Test plan

  • 👀

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@tnowacki tnowacki requested a review from a team February 6, 2025 02:51
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 3:32am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 3:32am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 3:32am

@tnowacki tnowacki changed the title [exp-to-insta][11/n] Migrate move-stackless-bytecode [exp-to-insta][11/n] Migrate move-stackless-bytecode and move-model Feb 6, 2025
Copy link
Contributor

@tzakian tzakian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the prover-test-utils crate go too!

@@ -38,7 +38,6 @@ exclude = [
"external-crates/move/crates/move-model",
"external-crates/move/crates/move-package",
"external-crates/move/crates/move-proc-macros",
"external-crates/move/crates/move-prover-test-utils",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnowacki tnowacki merged commit 9a714bd into MystenLabs:main Feb 11, 2025
43 checks passed
@tnowacki tnowacki deleted the insta-sb branch February 11, 2025 02:42
tnowacki added a commit that referenced this pull request Feb 11, 2025
## Description 

- Stacked on #21109 #21111 #21112 
- Remove update baseline functions
  - Kept in the sandbox command for Move CLI tests 
- Cleaned up transactional test runner

## Test plan 

- 👀 

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] gRPC:
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
zeevmoney added a commit to dwallet-labs/sui that referenced this pull request Feb 12, 2025
* 'main' of https://github.com/MystenLabs/sui: (84 commits)
  [Consensus] enable the new linearize logic for devnet. (MystenLabs#21172)
  Minor change to indicate that GraphQL is at alpha, not at beta (MystenLabs#21169)
  feat: add zklogin verify endpoint to jsonrpc (MystenLabs#21166)
  [sui-adapter] Remove error traces from native functions (MystenLabs#21185)
  [consensus] Enable zstd compression for consensus tonic network in mainnet (MystenLabs#21177)
  Reduce thread stall log level from ERROR to WARN (MystenLabs#21175)
  proto: sort fds files for stable codegen
  rpc: impl Name for google.rpc types
  rpc: properly return error code
  rpc: remove reqwest dependency
  grpc: add protos for more well known types
  proto: rework directory structure to conform with standards
  Update publish.mdx (MystenLabs#21170)
  Update ptb.mdx (MystenLabs#21171)
  [exp-to-insta][14/14] Cleanup of insta_assert macro (MystenLabs#21114)
  fix(sui): fix Option<address> serialization in client_ptb (MystenLabs#21126)
  [exp-to-insta][13/n] Cleanup insta migration (MystenLabs#21113)
  [exp-to-insta][12/n] Migrate move-analyzer (MystenLabs#21112)
  [exp-to-insta][11/n] Migrate move-stackless-bytecode and move-model (MystenLabs#21111)
  [exp-to-insta][10/n] Migrate move-unit-test (MystenLabs#21109)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants