Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consensus] Enable zstd compression in tonic network #20978

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

arun-koshy
Copy link
Contributor

@arun-koshy arun-koshy commented Jan 24, 2025

Description

In an effort to save on network egress/ingress and potentially help with latency/throughput we will enable grpc compression for consensus.

Zstd was chosen over Gzip because it offers better compression and decompression speeds. Additionally it claims to achieve better compression ratios, allowing for more efficient use of bandwidth. The flexibility of Zstd in adjusting compression levels can also be explored further if needed.

Test plan

With compression
Screenshot 2025-01-24 at 9 58 55 PM

Without compression
Screenshot 2025-01-24 at 10 00 04 PM


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol: Enable Zstandard compression for consensus tonic network in Testnet.
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@arun-koshy arun-koshy requested review from a team and mystenmark as code owners January 24, 2025 21:51
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 7:22pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 7:22pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 7:22pm

@arun-koshy arun-koshy temporarily deployed to sui-typescript-aws-kms-test-env January 24, 2025 21:51 — with GitHub Actions Inactive
Copy link
Contributor

@mwtian mwtian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if guarding with protocol config is needed, but either way lgtm.

@arun-koshy arun-koshy temporarily deployed to sui-typescript-aws-kms-test-env January 27, 2025 19:21 — with GitHub Actions Inactive
@arun-koshy arun-koshy merged commit 60f8765 into main Jan 27, 2025
50 of 51 checks passed
@arun-koshy arun-koshy deleted the ak/grpc-compression branch January 27, 2025 22:05
Copy link
Contributor

@akichidis akichidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants