genesis: begin reworking genesis to enable deterministic initialization of initial chain state #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the genesis free function and instead completely rely on ConfigBuilder + GenesisBuilder for performing genesis.
Merged
oxade
reviewed
May 16, 2022
| @@ -403,7 +403,7 @@ async fn test_custom_genesis_with_custom_move_package() -> Result<(), anyhow::Er | |||
| // Checks network config contains package ids | |||
| let network_conf = | |||
| PersistedConfig::<NetworkConfig>::read(&working_dir.join(SUI_NETWORK_CONFIG))?; | |||
| assert_eq!(2, network_conf.loaded_move_packages().len()); | |||
| // assert_eq!(2, network_conf.loaded_move_packages().len()); | |||
oxade
reviewed
May 16, 2022
Comment on lines
+145
to
+146
| // let move_framework = | ||
| // Object::new_package(move_modules.clone(), TransactionDigest::genesis()); |
There was a problem hiding this comment.
Suggested change
| // let move_framework = | |
| // Object::new_package(move_modules.clone(), TransactionDigest::genesis()); |
oxade
reviewed
May 16, 2022
Comment on lines
+122
to
+125
| // pub fn add_account(mut self, config: AccountConfig) -> Self { | ||
| // self.accounts.push(config); | ||
| // self | ||
| // } |
There was a problem hiding this comment.
Suggested change
| // pub fn add_account(mut self, config: AccountConfig) -> Self { | |
| // self.accounts.push(config); | |
| // self | |
| // } |
oxade
reviewed
May 16, 2022
| // let move_framework = | ||
| // Object::new_package(move_modules.clone(), TransactionDigest::genesis()); | ||
| modules.push(move_modules); | ||
| // objects.push(move_framework); |
There was a problem hiding this comment.
Suggested change
| // objects.push(move_framework); |
oxade
reviewed
May 16, 2022
| ); | ||
| let sui_modules = | ||
| sui_framework::get_sui_framework_modules(&sui_framework_lib_path).unwrap(); | ||
| // let sui_framework = Object::new_package(sui_modules.clone(), TransactionDigest::genesis()); |
There was a problem hiding this comment.
Suggested change
| // let sui_framework = Object::new_package(sui_modules.clone(), TransactionDigest::genesis()); |
oxade
reviewed
May 16, 2022
| sui_framework::get_sui_framework_modules(&sui_framework_lib_path).unwrap(); | ||
| // let sui_framework = Object::new_package(sui_modules.clone(), TransactionDigest::genesis()); | ||
| modules.push(sui_modules); | ||
| // objects.push(sui_framework); |
There was a problem hiding this comment.
Suggested change
| // objects.push(sui_framework); |
|
most of the things commented out were mostly around a "we probably want to do this but so I don't forget i'll comment it out". Which should be fixed on a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, in order to initialize a validator's initial chain state we need to disseminate a "GenesisConfig" which the validator then attempts to re-perform the entire genesis process from scratch. Unfortunately this process can be non-deterministic if configured to generate accounts without a pre-set address.
This PR changes this process by instead allowing for the genesis ceremony to be performed a single time and then have the resulting state packaged in a
Genesisstruct, which is then included in a validator'sValidatorConfig. This resulting state can be used to deterministically populate the initial state of the chain. More specifically, when a validator starts up and its storage is empty, it will process the contents of theGenesisstruct to populate storage with the initial state of the chain.This builds off of #1939 and implements the missing piece required for deployment as a validator's
ValidatorConfigwill have a complete picture of everything a validator will need when starting up.There is still a bit more work to be done to make the genesis process a bit cleaner. Ideally genesis would be a single Transaction Certificate and this is a step toward that reality.