[Example/CLI] Tic-tac-toe #18557

amnn · 2024-07-08T15:56:58Z

Description

Write a CLI to talk to the shared and multi-sig tic-tac-toe example
Move packages.

Test plan

Manual testing:

$ tic-tac-toe view 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed
                                X | O |
                               ---+---+---
                                O | X |
                               ---+---+---
                                  |   | X

    X: <address>
 -> O: <address>
 GAME: 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed
ADMIN: <public key>

                                 X WINS!

Also, confirmed that the CLI works with the React front-end.

Stack

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

vercel · 2024-07-08T15:57:01Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 11, 2024 11:46pm

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview	Jul 11, 2024 11:46pm
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview	Jul 11, 2024 11:46pm
sui-typescript-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 11, 2024 11:46pm

amnn · 2024-07-08T15:58:01Z

examples/tic-tac-toe/cli/Cargo.lock

The fact that almost 7000 lines of this PR is just the lock file is ...insane. We shouldn't need this many deps to write a demo app.

amnn · 2024-07-09T13:40:54Z

In #18526 I left an experience report for the front-end, here's the same for the CLI! Mostly relevant to @wlmyng and @stefan-mysten as it may implications on the design of the new CLI or Rust GraphQL SDK:

Compared to the TS SDK, the process is a little less polished here. I don't think that's a surprise to anyone, but hopefully we can tackle these paper cuts in our upcoming plans!

Examples

I relied heavily on @stefan-mysten's recent work in the CLI to act as a reference for how to build transactions. That's interesting for two reasons:

It made me realise that our CLI is actually potentially a good example, and we should perhaps leverage it more in that capacity, because we actively work on it.
Some of the things I was using it as an example for should arguably be part of the SDK.

Transaction building

The process of building a transaction is a muddled: We offer the ProgrammableTransactionBuilder API, and the TransactionBuilder API, functions accept a mix of their own types and core types when it comes to dealing with arguments.
We are missing some conveniences that the TS SDK has, like the ability to reference an object by its ID and resolve it to a ref, or a gas estimation API.

Coin Selection

This logic is duplicated across multiple sites (in the transaction builder API, in the coin read API), with different sets of capabilities:

One of these is a private impl, another is public.
One offers multiple coins, the other only one.
One supports sponsorship, the other should not.

There should be one such API, it belongs in the SDK, and it needs to support gas smashing and sponsorship.

Wallet vs SDK vs CLI

In all the points above, there is a component to the feedback that is "the right implementation exists somewhere, but it's probably in the wrong place, which makes it either impossible/hard to find, or not general enough for an SDK). There needs to be a clear separation between the SDK and Wallet libraries, and the CLI:

The SDK is responsible for abstracting away access to the RPC, which includes: transaction resolution, coin management, dry-run, dev-inspect, transaction building, reads.
The Wallet is responsible for abstracting away access to a secure key store, exposing transaction signing, and perhaps also "environments".
The CLI, which is porcelain for these libraries, but also has responsibilities related binary management (self-updates, extensions, etc).

Signing

The wallet's sign_transaction API will panic (unwrap) if the signature fails, which makes it difficult to use as a library -- we shouldn't do that.

Internal APIs

In a couple of places, we've exposed internal APIs because they offer the functionality that people needed, but we need to revisit these decisions -- we are often exposing too much or not enough by doing this.

For example, by exposing our internal PTB building APIs, we are also exposing people to the Identifier API, which makes sure only valid identifiers are supplied instead of arbitrary strings when dealing with module and function names.

This is helpful for sui internals to make sure that validation has happened, but adds too much noise for builders who need to create such an identifier and then unwrap it.

Errors

I made a typo ina function name in a PTB call and the only error I got back was VMVerificationOrDeserializationError, which is quite difficult to diagnose.

Crates

Users need to bring in multiple of our crates to get started. This example required sui-sdk, sui-keys, sui-types, shared-crypto, move-core-types, fastcrypto. Also, as noted by an earlier inline comment, the majority of this PR is actually the lock file, which is almost 7000 lines long.

When it comes to the dependencies we are taking directly, these should either be built into an SDK and exported if they are expected to always be useful, or gated behind a feature flag (but again, still part of the SDK).

When it comes to the large number of transitive dependencies, we need to do a better job keeping this number down.

## Description Write a CLI to talk to the shared and multi-sig tic-tac-toe example Move packages. ## Test plan Manual testing: ``` $ tic-tac-toe view 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed X | O | ---+---+--- O | X | ---+---+--- | | X X: <address> -> O: <address> GAME: 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed ADMIN: <public key> X WINS! ``` Also, confirmed that the CLI works with the React front-end.

It needs to "float" on top of the deps that get pulled in by the workspace.

examples/tic-tac-toe/cli/src/client.rs

stefan-mysten · 2024-07-11T15:48:26Z

examples/tic-tac-toe/cli/src/client.rs

+            default.extend([".sui", "sui_config", "client.yaml"]);
+            Some(default)
+        }) else {
+            bail!("Can't find Wallet config");


Suggested change

bail!("Can't find Wallet config");

bail!("Cannot find wallet config in the known default directory {}", path);

examples/tic-tac-toe/cli/src/client.rs

stefan-mysten

Looks good, left a few comments.

nit #1:
let mut builder everywhere, but then let g = instead of let game Not sure it saves a lot of typing, but it's probably a matter of preference. I always need to think hard for a few seconds to figure out what this single letter variable refers to.
nit #2: some places the error message ends with a . in others it doesn't.

examples/tic-tac-toe/cli/src/client.rs

stefan-mysten · 2024-07-11T15:55:56Z

examples/tic-tac-toe/cli/src/client.rs

+        }
+
+        // (3) Deserialize contents
+        let kind = match raw.type_.module.as_str() {


Slightly confused as to why this is matched on a string? Isn't there a well defined type/enum for possible modules?

Not sure what type/enum you're referring to -- this is the module for a StructTag, it's an arbitrary Identifier, and we are viewing it as a &str to avoid having to create new Identifiers to compare against it.

stefan-mysten · 2024-07-11T15:58:53Z

examples/tic-tac-toe/cli/src/client.rs

+        builder.programmable_move_call(
+            self.package,
+            raw.type_.module.clone(),
+            Identifier::new("ended").unwrap(),


How do we know this game ended?

This function $PKG::$KIND::ended is what tells us whether the game has ended (one of the players has won, or there is a draw), we are making this dev inspect call to re-use the logic in the Move package to answer this question for us.

stefan-mysten · 2024-07-11T16:01:13Z

examples/tic-tac-toe/cli/src/client.rs

+
+        let results = client
+            .read_api()
+            .dev_inspect_transaction_block(


Is this dev_inspect_transaction_block used before actually executing the last move to determine if this last move leads to the end of game?

This dev inspect call is used to determine if the game has already ended. We run it every time we load the Game. When we make a move, we issue the transaction and then we read the Game state, so at that point we will see whether the game has ended, to display that.

stefan-mysten · 2024-07-11T16:11:52Z

examples/tic-tac-toe/cli/src/client.rs

+        let DryRunTransactionBlockResponse { effects, .. } = client
+            .read_api()
+            .dry_run_transaction_block(tx_data.clone())
+            .await
+            .context("Error estimating gas budget")?;
+
+        let gas_used = effects.gas_cost_summary();
+        let overhead = 1000 * gas_price;
+        let net_used = gas_used.net_gas_usage();
+        let computation = gas_used.computation_cost;
+
+        let budget = overhead + (net_used.max(0) as u64).max(computation);


this tells me that the overhead function in the CLI dry_run logic should be part of the SDK.

Agreed -- we should expose gas estimation in the SDK.

stefan-mysten · 2024-07-11T16:12:36Z

examples/tic-tac-toe/cli/src/client.rs

+    async fn max_gas_budget(&self) -> Result<u64> {
+        let client = self.client().await?;
+
+        let cfg = client.read_api().get_protocol_config(None).await?;
+        let Some(Some(SuiProtocolConfigValue::U64(max))) = cfg.attributes.get("max_tx_gas") else {
+            bail!("Couldn't find max gas budget");
+        };
+
+        Ok(*max)
+    }


Same with this one, should be part of an SDK.

stefan-mysten · 2024-07-11T16:14:42Z

examples/tic-tac-toe/cli/src/client.rs

+    async fn select_coins(
+        &self,
+        owner: SuiAddress,
+        balance: u64,
+        tx: &TransactionKind,
+    ) -> Result<Vec<ObjectRef>> {
+        let client = self.client().await?;
+        let coins = client.coin_read_api();
+        let exclude: Vec<_> = tx
+            .input_objects()?
+            .into_iter()
+            .filter_map(|input| match input {
+                InputObjectKind::ImmOrOwnedMoveObject((id, _, _)) => Some(id),
+                InputObjectKind::MovePackage(_) => None,
+                InputObjectKind::SharedMoveObject { .. } => None,
+            })
+            .collect();
+
+        Ok(coins
+            .select_coins(owner, None, balance as u128, exclude)
+            .await?
+            .into_iter()
+            .map(|coin| coin.object_ref())
+            .collect())
+    }


I might be mistaking, but the wallet already provides this kind of functionality, so maybe you do not need to reimplement?
https://github.com/MystenLabs/sui/blob/main/crates/sui-sdk/src/wallet_context.rs#L180

Oh, nice -- yes, I can use that (this conceptually belongs in the SDK though) -- the only potential concern is that it returns a single coin, so it doesn't support gas smashing, but that's not a big deal for this demo.

stefan-mysten · 2024-07-11T16:15:31Z

examples/tic-tac-toe/cli/src/command.rs

+
+    /// Delete a finished game.
+    Delete {
+        /// ID of the game to view.


Suggested change

/// ID of the game to view.

/// ID of the game to delete.

stefan-mysten · 2024-07-11T16:16:06Z

examples/tic-tac-toe/cli/src/command.rs

+                ensure!(
+                    !*shared || !*multi_sig,
+                    "Cannot specify both shared and multi-sig"
+                );


I always find this macro hard hard to reason about.

Probably might be better to use https://docs.rs/clap/latest/clap/struct.Arg.html#method.conflicts_with

amnn

Thanks for the thorough review @stefan-mysten ! Will address these comments and re-request review.

amnn · 2024-07-11T16:52:14Z

examples/tic-tac-toe/cli/src/client.rs

+        let DryRunTransactionBlockResponse { effects, .. } = client
+            .read_api()
+            .dry_run_transaction_block(tx_data.clone())
+            .await
+            .context("Error estimating gas budget")?;
+
+        let gas_used = effects.gas_cost_summary();
+        let overhead = 1000 * gas_price;
+        let net_used = gas_used.net_gas_usage();
+        let computation = gas_used.computation_cost;
+
+        let budget = overhead + (net_used.max(0) as u64).max(computation);


Agreed -- we should expose gas estimation in the SDK.

amnn · 2024-07-11T16:53:16Z

examples/tic-tac-toe/cli/src/client.rs

+    async fn select_coins(
+        &self,
+        owner: SuiAddress,
+        balance: u64,
+        tx: &TransactionKind,
+    ) -> Result<Vec<ObjectRef>> {
+        let client = self.client().await?;
+        let coins = client.coin_read_api();
+        let exclude: Vec<_> = tx
+            .input_objects()?
+            .into_iter()
+            .filter_map(|input| match input {
+                InputObjectKind::ImmOrOwnedMoveObject((id, _, _)) => Some(id),
+                InputObjectKind::MovePackage(_) => None,
+                InputObjectKind::SharedMoveObject { .. } => None,
+            })
+            .collect();
+
+        Ok(coins
+            .select_coins(owner, None, balance as u128, exclude)
+            .await?
+            .into_iter()
+            .map(|coin| coin.object_ref())
+            .collect())
+    }


Oh, nice -- yes, I can use that (this conceptually belongs in the SDK though) -- the only potential concern is that it returns a single coin, so it doesn't support gas smashing, but that's not a big deal for this demo.

amnn · 2024-07-11T16:59:28Z

examples/tic-tac-toe/cli/src/client.rs

+        game: &game::Owned,
+        game_ref: ObjectRef,


They do refer to the same game. The first parameter is the contents of the game, read from RPC, and the second is its identity, which can be used to refer to it in a transaction.

This data exists together in the overall Game struct, but we don't want to pass that in directly because then the function would need to check that the game it was given was an "owned" Game. Requesting the data in this way passes responsibility to the caller to do the check first and provide only the relevant information.

amnn · 2024-07-11T17:00:33Z

examples/tic-tac-toe/cli/src/client.rs

+        }
+
+        // (3) Deserialize contents
+        let kind = match raw.type_.module.as_str() {


Not sure what type/enum you're referring to -- this is the module for a StructTag, it's an arbitrary Identifier, and we are viewing it as a &str to avoid having to create new Identifiers to compare against it.

amnn · 2024-07-11T17:01:44Z

examples/tic-tac-toe/cli/src/client.rs

+        builder.programmable_move_call(
+            self.package,
+            raw.type_.module.clone(),
+            Identifier::new("ended").unwrap(),


This function $PKG::$KIND::ended is what tells us whether the game has ended (one of the players has won, or there is a draw), we are making this dev inspect call to re-use the logic in the Move package to answer this question for us.

amnn · 2024-07-11T17:03:13Z

examples/tic-tac-toe/cli/src/client.rs

+
+        let results = client
+            .read_api()
+            .dev_inspect_transaction_block(


This dev inspect call is used to determine if the game has already ended. We run it every time we load the Game. When we make a move, we issue the transaction and then we read the Game state, so at that point we will see whether the game has ended, to display that.

examples/tic-tac-toe/cli/src/client.rs

amnn · 2024-07-11T17:07:20Z

examples/tic-tac-toe/cli/src/client.rs

+        };
+
+        let Some(raw) = raw.try_as_move() else {
+            bail!("It is a package, not a object.");


Suggested change

bail!("It is a package, not a object.");

bail!("It is a package, not an object.");

examples/tic-tac-toe/cli/src/client.rs

amnn

All comments should be addressed now, could you take another look @stefan-mysten ?

stefan-mysten

LGTM

## Description A README for the tic-tac-toe app example, derived from: https://github.com/MystenLabs/multisig_tic-tac-toe/blob/main/README.md And updates to the docs for the tic-tac-toe app example to reflect changes to modernise the guide and bring all its source code into the `sui` mono-repo. This is the last major example that lived in the `sui_programmability` directory. ## Test plan :eyes: ## Stack - #18525 - #18526 - #18557 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

…8595) ## Description Replace all references to Move packages in `sui_programmability` with equivalents in `./examples/move`, in preparation for deleting the programmability directory. In the process, I also: - removed the tic-tac-toe example from the Sui SDK, as it has been replaced by a more full-featured E2E example. - ported some modernised versions of the `basics` packages into the new `examples/move/basics` for use in tests. ## Test plan CI and, ``` sui$ cargo simtest ``` ## Stack - #18525 - #18526 - #18557 - #18558 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

…18609) ## Description Port over the following examples from sui_programmability/examples: - crypto/sources/ecdsa.move - crypto/sources/groth16.move - ~games/sources/drand_lib.move~ - ~games/sources/drand_based_lottery.move~ - ~games/sources/drand_based_scratch_card.move~ - games/sources/vdf_based_lottery.move Modernising and cleaning them up in the process: - Applying wrapping consistently at 100 characters, and cleaning up comments. - Removing unnecessary use of `entry` functions, including returning values instead of transfering to sender in some cases. - Using receiver functions where possible. - Standardising file order and adding titles for sections. - Standardising use of doc comments vs regular comments. - Using clever errors. This marks the final set of examples to be moved out of sui-programmability, which will then be deleted. ## Test plan ``` sui-framework-tests$ cargo nextest run -- run_examples_move_unit_tests ``` ## Stack - #18525 - #18526 - #18557 - #18558 - #18595 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

## Description Remove the `sui_programmability` folder as all examples have been ported and modernised to `examples/move`, or elsewhere. ## Test plan CI ## Stack - #18525 - #18526 - #18557 - #18558 - #18595 - #18609 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

## Description Write a CLI to talk to the shared and multi-sig tic-tac-toe example Move packages. ## Test plan Manual testing: ``` $ tic-tac-toe view 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed X | O | ---+---+--- O | X | ---+---+--- | | X X: <address> -> O: <address> GAME: 0xab06bb92cc1e6c95f9e6eed7e6c01fade6bb5eaa241e2100eb54d914597295ed ADMIN: <public key> X WINS! ``` Also, confirmed that the CLI works with the React front-end. ## Stack - MystenLabs#18525 - MystenLabs#18526 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:

## Description A README for the tic-tac-toe app example, derived from: https://github.com/MystenLabs/multisig_tic-tac-toe/blob/main/README.md And updates to the docs for the tic-tac-toe app example to reflect changes to modernise the guide and bring all its source code into the `sui` mono-repo. This is the last major example that lived in the `sui_programmability` directory. ## Test plan :eyes: ## Stack - MystenLabs#18525 - MystenLabs#18526 - MystenLabs#18557 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

…stenLabs#18595) ## Description Replace all references to Move packages in `sui_programmability` with equivalents in `./examples/move`, in preparation for deleting the programmability directory. In the process, I also: - removed the tic-tac-toe example from the Sui SDK, as it has been replaced by a more full-featured E2E example. - ported some modernised versions of the `basics` packages into the new `examples/move/basics` for use in tests. ## Test plan CI and, ``` sui$ cargo simtest ``` ## Stack - MystenLabs#18525 - MystenLabs#18526 - MystenLabs#18557 - MystenLabs#18558 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

…ystenLabs#18609) ## Description Port over the following examples from sui_programmability/examples: - crypto/sources/ecdsa.move - crypto/sources/groth16.move - ~games/sources/drand_lib.move~ - ~games/sources/drand_based_lottery.move~ - ~games/sources/drand_based_scratch_card.move~ - games/sources/vdf_based_lottery.move Modernising and cleaning them up in the process: - Applying wrapping consistently at 100 characters, and cleaning up comments. - Removing unnecessary use of `entry` functions, including returning values instead of transfering to sender in some cases. - Using receiver functions where possible. - Standardising file order and adding titles for sections. - Standardising use of doc comments vs regular comments. - Using clever errors. This marks the final set of examples to be moved out of sui-programmability, which will then be deleted. ## Test plan ``` sui-framework-tests$ cargo nextest run -- run_examples_move_unit_tests ``` ## Stack - MystenLabs#18525 - MystenLabs#18526 - MystenLabs#18557 - MystenLabs#18558 - MystenLabs#18595 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

## Description Remove the `sui_programmability` folder as all examples have been ported and modernised to `examples/move`, or elsewhere. ## Test plan CI ## Stack - MystenLabs#18525 - MystenLabs#18526 - MystenLabs#18557 - MystenLabs#18558 - MystenLabs#18595 - MystenLabs#18609 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: Ronny Roland <[email protected]>

amnn requested review from wlmyng, stefan-mysten and a team July 8, 2024 15:56

amnn self-assigned this Jul 8, 2024

amnn commented Jul 8, 2024

View reviewed changes

amnn mentioned this pull request Jul 8, 2024

[Examples/Docs] Tic-tac-toe #18558

Merged

7 tasks

amnn force-pushed the amnn/eg-ttt-cli branch from 60bf1e5 to e3925a1 Compare July 9, 2024 11:28

vercel bot deployed to Preview – sui-docs July 9, 2024 11:30 View deployment

amnn force-pushed the amnn/eg-ttt-ui branch from 4486b5e to 8a62870 Compare July 9, 2024 12:09

amnn requested a review from ronny-mysten as a code owner July 9, 2024 12:09

amnn force-pushed the amnn/eg-ttt-cli branch from e3925a1 to 4b9624a Compare July 9, 2024 12:09

vercel bot deployed to Preview – sui-docs July 9, 2024 12:12 View deployment

amnn mentioned this pull request Jul 10, 2024

[Examples] Remove references to sui_programmability in codebase #18595

Merged

7 tasks

amnn force-pushed the amnn/eg-ttt-ui branch from 8a62870 to 34aba6e Compare July 10, 2024 23:14

amnn force-pushed the amnn/eg-ttt-cli branch from 4b9624a to faf9e5d Compare July 10, 2024 23:14

vercel bot deployed to Preview – sui-docs July 10, 2024 23:18 View deployment

amnn force-pushed the amnn/eg-ttt-cli branch from faf9e5d to 0b25e14 Compare July 10, 2024 23:33

vercel bot deployed to Preview – sui-docs July 10, 2024 23:35 View deployment

amnn force-pushed the amnn/eg-ttt-ui branch from 2074b61 to f308c58 Compare July 11, 2024 10:49

amnn force-pushed the amnn/eg-ttt-cli branch from 0b25e14 to 46667da Compare July 11, 2024 10:49

vercel bot deployed to Preview – sui-docs July 11, 2024 10:54 View deployment

Base automatically changed from amnn/eg-ttt-ui to main July 11, 2024 11:36

amnn added 4 commits July 11, 2024 15:26

fixup: remove localnet.env from CLI codebase

89948de

fixup: ignore localnet.env

95b7488

fixup: Don't check in Cargo.lock for the example

7d1293f

It needs to "float" on top of the deps that get pulled in by the workspace.

amnn force-pushed the amnn/eg-ttt-cli branch from 46667da to 7d1293f Compare July 11, 2024 14:26

vercel bot deployed to Preview – sui-docs July 11, 2024 14:29 View deployment

stefan-mysten reviewed Jul 11, 2024

View reviewed changes

examples/tic-tac-toe/cli/src/client.rs Outdated Show resolved Hide resolved

stefan-mysten reviewed Jul 11, 2024

View reviewed changes

examples/tic-tac-toe/cli/src/client.rs Show resolved Hide resolved

stefan-mysten reviewed Jul 11, 2024

View reviewed changes

amnn commented Jul 11, 2024

View reviewed changes

This was referenced Jul 11, 2024

[Examples/Move] Port remaining Crypto Sui Programmability Examples #18609

Merged

[Examples/Move] Delete sui_programmability #18612

Merged

[Examples/CLI] fixup: address comments

26c668b

amnn requested a review from stefan-mysten July 11, 2024 23:42

amnn commented Jul 11, 2024

View reviewed changes

vercel bot deployed to Preview – sui-docs July 11, 2024 23:46 View deployment

stefan-mysten approved these changes Jul 11, 2024

View reviewed changes

amnn merged commit d3c6dce into main Jul 12, 2024
48 checks passed

amnn deleted the amnn/eg-ttt-cli branch July 12, 2024 01:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Example/CLI] Tic-tac-toe #18557

[Example/CLI] Tic-tac-toe #18557

amnn commented Jul 8, 2024 •

edited

Loading

vercel bot commented Jul 8, 2024 •

edited

Loading

amnn Jul 8, 2024

amnn commented Jul 9, 2024

stefan-mysten Jul 11, 2024 •

edited

Loading

stefan-mysten left a comment

stefan-mysten Jul 11, 2024

amnn Jul 11, 2024

stefan-mysten Jul 11, 2024

amnn Jul 11, 2024

stefan-mysten Jul 11, 2024

amnn Jul 11, 2024

stefan-mysten Jul 11, 2024

amnn Jul 11, 2024

stefan-mysten Jul 11, 2024

stefan-mysten Jul 11, 2024

amnn Jul 11, 2024

stefan-mysten Jul 11, 2024

stefan-mysten Jul 11, 2024

stefan-mysten Jul 11, 2024

amnn left a comment

amnn Jul 11, 2024

amnn Jul 11, 2024

amnn Jul 11, 2024

amnn Jul 11, 2024

amnn Jul 11, 2024

amnn Jul 11, 2024

amnn Jul 11, 2024

amnn left a comment

stefan-mysten left a comment

	bail!("Can't find Wallet config");
	bail!("Cannot find wallet config in the known default directory {}", path);

	bail!("It is a package, not a object.");
	bail!("It is a package, not an object.");

[Example/CLI] Tic-tac-toe #18557

[Example/CLI] Tic-tac-toe #18557

Conversation

amnn commented Jul 8, 2024 • edited Loading

Description

Test plan

Stack

Release notes

vercel bot commented Jul 8, 2024 • edited Loading

Choose a reason for hiding this comment

amnn commented Jul 9, 2024

Examples

Transaction building

Coin Selection

Wallet vs SDK vs CLI

Signing

Internal APIs

Errors

Crates

stefan-mysten Jul 11, 2024 • edited Loading

Choose a reason for hiding this comment

stefan-mysten left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amnn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amnn left a comment

Choose a reason for hiding this comment

stefan-mysten left a comment

Choose a reason for hiding this comment

amnn commented Jul 8, 2024 •

edited

Loading

vercel bot commented Jul 8, 2024 •

edited

Loading

stefan-mysten Jul 11, 2024 •

edited

Loading