Defer all possible errors from connect_lazy until request time #18536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
bmwill
approved these changes
Jul 5, 2024
lxfind
reviewed
Jul 5, 2024
| @@ -90,7 +93,7 @@ pub trait AuthorityAPI { | |||
|
|
|||
| #[derive(Clone)] | |||
| pub struct NetworkAuthorityClient { | |||
| client: ValidatorClient<Channel>, | |||
| client: SuiResult<ValidatorClient<Channel>>, | |||
There was a problem hiding this comment.
Probably better to just use Option instead of SuiResult?
There was a problem hiding this comment.
The idea is that this propagates the actual error though
mystenmark
force-pushed
the
mlogan-fix-connect-lazy
branch
from
9aa3fe9 to
3a3b007
Compare
mystenmark
added a commit
that referenced
this pull request
Jul 5, 2024
Merged
mystenmark
added a commit
that referenced
this pull request
Jul 5, 2024
mystenmark
added a commit
that referenced
this pull request
Jul 5, 2024
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.