[CLI] Fix config option for when a file or folder is passed. #18469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pted a network config, and sui-test-validator accepts a config directory, so we need to support both
|
@stefan-mysten is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amnn
approved these changes
Jul 1, 2024
stefan-mysten
added a commit
to stefan-mysten/sui
that referenced
this pull request
Jul 1, 2024
…abs#18469) ## Description Prior to MystenLabs#18204, `sui start` accepted a network config file when using `--network.config`, and `sui-test-validator` accepted a config directory when using the `--config-dir`, so we need to support both. That PR introduces a bug as in it accepts only directories. This PR fixes this issue and should close MystenLabs#18468. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
7 tasks
stefan-mysten
added a commit
that referenced
this pull request
Jul 1, 2024
## Description Cherry pick #18469 into release branch v1.28 Prior to #18204, `sui start` accepted a network config file when using `--network.config`, and `sui-test-validator` accepted a config directory when using the `--config-dir`, so we need to support both. That PR introduces a bug as in it accepts only directories. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
stefan-mysten
added a commit
that referenced
this pull request
Jul 12, 2024
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
…abs#18469) ## Description Prior to MystenLabs#18204, `sui start` accepted a network config file when using `--network.config`, and `sui-test-validator` accepted a config directory when using the `--config-dir`, so we need to support both. That PR introduces a bug as in it accepts only directories. This PR fixes this issue and should close MystenLabs#18468. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to #18204,
sui startaccepted a network config file when using--network.config, andsui-test-validatoraccepted a config directory when using the--config-dir, so we need to support both. That PR introduces a bug as in it accepts only directories.This PR fixes this issue and should close #18468.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.