[bridge indexer] query transactions #18400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
dariorussi
reviewed
Jun 25, 2024
| @@ -11,6 +11,13 @@ pub struct ProgressStore { | |||
| pub checkpoint: i64, | |||
| } | |||
|
|
|||
| #[derive(Queryable, Selectable, Insertable, Identifiable, Debug)] | |||
| #[diesel(table_name = sui_progress_store, primary_key(txn_digest))] | |||
| pub struct SuiProgressStore { | |||
There was a problem hiding this comment.
not sure I understand the reason for this table. Or maybe whether we should have one table that tracks progress for different tasks
There was a problem hiding this comment.
it's for tracking query cursor as you know. The cursor is an TransactionDigest so better to be stored as bytes. We can tweak the existing table progress_store to consolidate, but i don't know if we want to do it now (cuz it may break currently running indexer if we are not careful enough)
| indexer_meterics, | ||
| ingestion_metrics, | ||
| ); | ||
| if let Some(sui_rpc_url) = config.sui_rpc_url.clone() { |
There was a problem hiding this comment.
I'd like to talk about how we plug in a data reader. Let's make sure to talk at our daily later
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
f3d0fb8 to
59d6a5e
Compare
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
59d6a5e to
4a660f3
Compare
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
4a660f3 to
bf53aa0
Compare
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
c62a9a9 to
7b6674b
Compare
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
7b6674b to
6d4d000
Compare
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
6d4d000 to
4a458f4
Compare
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
4a458f4 to
06d4c24
Compare
dariorussi
approved these changes
Jun 26, 2024
longbowlu
force-pushed
the
bridge-indexer-query-tx
branch
from
06d4c24 to
6839973
Compare
tx-tomcat
pushed a commit
to tx-tomcat/sui-network
that referenced
this pull request
Jul 29, 2024
## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.