Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick 18359 to 1.28.0 #18386

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

longbowlu
Copy link
Contributor

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

## Description 

1. emit CommitteeMemberUrlUpdateEvent when a validator updates url
2. add url checks when validator add or update bridge url
3. update a comment: the Blocklist payload contains 20 bytes evm
addresses instead of 33 bytes pub keys

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 5:53pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Jun 24, 2024 5:53pm
sui-kiosk ⬜️ Ignored (Inspect) Jun 24, 2024 5:53pm
sui-typescript-docs ⬜️ Ignored (Inspect) Jun 24, 2024 5:53pm

@longbowlu longbowlu changed the base branch from main to releases/sui-v1.28.0-release June 24, 2024 17:53
@longbowlu longbowlu enabled auto-merge (squash) June 24, 2024 18:01
@longbowlu longbowlu merged commit 1d48056 into releases/sui-v1.28.0-release Jun 24, 2024
49 checks passed
@longbowlu longbowlu deleted the cherry-pick-18359 branch June 24, 2024 18:21
longbowlu added a commit that referenced this pull request Jun 24, 2024
longbowlu added a commit that referenced this pull request Jun 24, 2024
This reverts commit 1d48056.

## Description 

Describe the changes or additions included in this PR.

## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants