Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Listen to all services in sui-test-validator #17777

Closed
wants to merge 3 commits into from

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented May 16, 2024

Description

sui-test-validator's faucet listen to all IPs (0.0.0.0)
fixes #15279

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

@howjmay howjmay requested review from joyqvq and patrickkuo as code owners May 16, 2024 18:40
Copy link

vercel bot commented May 16, 2024

@howjmay is attempting to deploy a commit to the Mysten Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 6:42pm

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 16, 2024
@stefan-mysten
Copy link
Member

Thanks! This was fixed with the removal of sui-test-validator and integrating the logic in sui start. See #18607.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start sui-test-validator (local network) inside docker container
2 participants