[sui-test-validator] update sui-test-validator options and dockerfile #14701
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
vladilen11
changed the title
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Is anyone could help this pr? I think this dockerfile is very useful for developers. @patrickkuo |
|
@vladilen11 is attempting to deploy a commit to the Mysten Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @vladilen11 Just to understand, what do you want to have in a Dockerfile, just a local network running? Important to note, we are just about to deprecate
Regarding the host and ports, I see the issue that you need to have the service listening on 0.0.0.0 for Docker to work properly. |
|
@stefan-mysten Yes, I want to be able to boot a localnet directly through docker, because sui-test-validator had a lot of people having problems(https://obelisk.build/engine/docs/quick-start/faq) with postgres before, so we want to start it through docker. Our primary goal in doing this is to allow move contract developers to focus their efforts on contract development rather than tedious environment configuration. You're right, the modification I gave to But since Also I observed that I still can't specify the address of the faucet or fullnode in the sui start command, I guess I can recreate a pr to refine the details here. |
|
@vladilen11 I have not forgot about this. Just put up a PR #18607 that should enable this for |
|
@vladilen11 everything now starts on |
## Description Make indexer, GraphQL, faucet hosts configurable. When using Docker, due to the way it sets up a network interface for the container, the services need to bind to 0.0.0.0 to be able to be accessed from outside the container. This PR enables configurable hosts for these three services via optional flags: - `--indexer-host 0.0.0.0` - `--faucet-host 0.0.0.0` - `--graphql-host 0.0.0.0` If no host flag is provided, it will use the default `0.0.0.0` one. In addition, I found a bug where if the `default_value` is not provided, calling `unwrap_or_default` will return value 0 (if that field is an int). For example, if we call `--with-graphql`, the indexer port would have been set to 0 because the `default_missing_value` is only set when the flag is passed, but not when it is not passed, which is the case here due `with-indexer` being implicit enabled. This supersedes MystenLabs#14701 and should close MystenLabs#14701. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [x] CLI: Changed `sui start` to allow configurable hosts for indexer (`--indexer-host `), GraphQL (`--graphql-host `), and faucet (`--faucet-host`) services. This will enable to use `sui start` from a Docker container. By default, all services start with `0.0.0.0` host. - [ ] Rust SDK:
Description
Give the address configuration to the developer allows for more flexibility in starting
sui-test-validator.Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
sui-test-validator change
sui-test-validator cmd:
127.0.0.10.0.0.0Add sui-test-validator Dockerfile
Hopefully the mystenlabs team will maintain a docker image of sui-test-validator, which is really important for developers.