Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-validator]change bind ip 127.0.0.1 to 0.0.0.0 #14697

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[test-validator]change bind ip 127.0.0.1 to 0.0.0.0 #14697

merged 2 commits into from
Dec 12, 2023

Conversation

uvd
Copy link
Contributor

@uvd uvd commented Nov 7, 2023

Description

change bind ip 127.0.0.1 to 0.0.0.0

Test Plan

N/A

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

change bind ip 127.0.0.1 to 0.0.0.0
Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:19pm
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:19pm
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:19pm
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:19pm
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:19pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2023 8:19pm

@stefan-mysten
Copy link
Member

This looks reasonable to me, thanks @uvd. Probably this will fix #15279. @oxade @amnn any issues with merging this?

@stefan-mysten stefan-mysten requested a review from oxade December 12, 2023 19:26
Copy link

vercel bot commented Dec 12, 2023

@stefan-mysten is attempting to deploy a commit to the Sui Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – mysten-ui December 12, 2023 20:19 Inactive
@stefan-mysten stefan-mysten merged commit fd09307 into MystenLabs:main Dec 12, 2023
38 of 39 checks passed
gdanezis pushed a commit that referenced this pull request Dec 15, 2023
## Description 

Change the bind ip `127.0.0.1` to `0.0.0.0` in `sui-test-validator`. This enables more flexibility in Docker containers.

## Test Plan 

N/A


### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Changed the bind ip `127.0.0.1` to `0.0.0.0` in `sui-test-validator`. This enables more flexibility in Docker containers.

Co-authored-by: stefan-mysten <[email protected]>
suiwombat pushed a commit that referenced this pull request Dec 19, 2023
## Description 

Change the bind ip `127.0.0.1` to `0.0.0.0` in `sui-test-validator`. This enables more flexibility in Docker containers.

## Test Plan 

N/A


### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Changed the bind ip `127.0.0.1` to `0.0.0.0` in `sui-test-validator`. This enables more flexibility in Docker containers.

Co-authored-by: stefan-mysten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants