Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explorer]: Add suins address resolver on object page #14449

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

plam-ml
Copy link
Contributor

@plam-ml plam-ml commented Oct 26, 2023

Description

Screenshot 2023-10-25 at 8 56 14 PM

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

@plam-ml plam-ml requested a review from a team as a code owner October 26, 2023 03:55
@plam-ml plam-ml requested review from mamos-mysten and Nikhil-Mysten and removed request for a team October 26, 2023 03:55
@vercel vercel bot temporarily deployed to Preview – mysten-ui October 26, 2023 03:55 Inactive
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 3:55am
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 3:55am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview Oct 26, 2023 3:55am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Oct 26, 2023 3:55am
sui-kiosk ⬜️ Ignored (Inspect) Oct 26, 2023 3:55am

@plam-ml plam-ml merged commit 94b2a13 into main Oct 26, 2023
35 checks passed
@plam-ml plam-ml deleted the APPS-1715 branch October 26, 2023 20:24
jonas-lj pushed a commit to jonas-lj/sui that referenced this pull request Nov 2, 2023
## Description 

- Add SUINS name resolver for object page
- https://mysten.atlassian.net/browse/APPS-1715

<img width="1409" alt="Screenshot 2023-10-25 at 8 56 14 PM"
src="https://github.com/MystenLabs/sui/assets/127577476/27187e1a-b1ee-473c-94ab-801c02d6d975">


## Test Plan 

How did you test the new or updated feature?

---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants