[Examples/Move][EASY] Change Directory #14429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
cgswords,
awelc,
tnowacki,
tzakian,
sblackshear,
dariorussi,
ronny-mysten and
healthydeve
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
As per discussion last week -- changing the name of the directory where Move examples are held.
|
healthydeve
approved these changes
Oct 25, 2023
damirka
approved these changes
Oct 25, 2023
tnowacki
approved these changes
Oct 25, 2023
oxade
added a commit
that referenced
this pull request
Oct 26, 2023
## Description Fixes breakage due to #14429 ## Test Plan Existing --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
amnn
added a commit
that referenced
this pull request
Oct 27, 2023
Move tests are run as part of the Rust tests for the Sui Framework, but they should also be run when there are only Move changes. Surfaced because a recent PR (#14429) Moved some Move tests causing CI to fail on `main`, and this wasn't picked up because diff tests hadn't been run. Test Plan: CI
amnn
added a commit
that referenced
this pull request
Oct 27, 2023
Move tests are run as part of the Rust tests for the Sui Framework, but they should also be run when there are only Move changes. Surfaced because a recent PR (#14429) Moved some Move tests causing CI to fail on `main`, and this wasn't picked up because diff tests hadn't been run. Test Plan: CI
amnn
added a commit
that referenced
this pull request
Oct 27, 2023
## Description Move tests are run as part of the Rust tests for the Sui Framework, but they should also be run when there are only Move changes. Surfaced because a recent PR (#14429) Moved some Move tests causing CI to fail on `main`, and this wasn't picked up because diff tests hadn't been run. ## Test Plan CI
jonas-lj
pushed a commit
to jonas-lj/sui
that referenced
this pull request
Nov 2, 2023
## Description As in title ## Test Plan 👀
jonas-lj
pushed a commit
to jonas-lj/sui
that referenced
this pull request
Nov 2, 2023
## Description Fixes breakage due to MystenLabs#14429 ## Test Plan Existing --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
jonas-lj
pushed a commit
to jonas-lj/sui
that referenced
this pull request
Nov 2, 2023
## Description Move tests are run as part of the Rust tests for the Sui Framework, but they should also be run when there are only Move changes. Surfaced because a recent PR (MystenLabs#14429) Moved some Move tests causing CI to fail on `main`, and this wasn't picked up because diff tests hadn't been run. ## Test Plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in title
Test Plan
👀